Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Move-PSKoanLibrary Function #364

Merged
merged 6 commits into from
Mar 2, 2020
Merged

Add Move-PSKoanLibrary Function #364

merged 6 commits into from
Mar 2, 2020

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Mar 1, 2020

PR Summary

Adds a Move-PSKoanLibrary public function which moves the entire PSKoans library folder and sets the new location in the module configuration.

Context

Resolves #325

Changes

  • Added Move-PSKoanLibrary command
  • Added tests for new command

Tangential:

  • Fixed a couple minor issues with Set-PSKoanLocation that I found in the process.
  • Added an automatic PSKoans. prefix for ErrorIds emitted from New-PSKoanErrorRecord

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Module Pertaining to the module's functionality itself. Category-Tests ✅ Pertaining to tests for the module functions. labels Mar 1, 2020
Copy link
Collaborator

@steviecoaster steviecoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Mar 2, 2020
@vexx32 vexx32 merged commit 29a7068 into master Mar 2, 2020
@vexx32 vexx32 deleted the Move-PSKoanLibrary branch March 2, 2020 14:51
@vexx32 vexx32 added this to In Progress in Module Features / Bugfixes Progress via automation Mar 3, 2020
@vexx32 vexx32 moved this from In Progress to Closed in Module Features / Bugfixes Progress Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Module Pertaining to the module's functionality itself. Category-Tests ✅ Pertaining to tests for the module functions.
Development

Successfully merging this pull request may close these issues.

Enable syncing of PSKoans to alternate locations
2 participants