Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#372) Fix issues in AboutEnumeration #373

Merged
merged 5 commits into from
Mar 6, 2020
Merged

(#372) Fix issues in AboutEnumeration #373

merged 5 commits into from
Mar 6, 2020

Commits on Mar 6, 2020

  1. ♻️ Cleanup old test file 

    Refactor slightly, match file more to current style.

Rename a few tests to make more sense.
    @vexx32
    vexx32 committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    798cc74 View commit details
    Browse the repository at this point in the history

  2. ✅ Add regression test 

    We can test file ASTs during our static analysis checks.

Added a test to check we don't have any nested It blocks in the file.
    @vexx32
    vexx32 committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    2d64c14 View commit details
    Browse the repository at this point in the history

  3. 🐛 (#372) Fix missing / extra brace

    @vexx32
    vexx32 committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    cfec99c View commit details
    Browse the repository at this point in the history

  4. 📝 🎨 Adjust AboutEnumeration formatting

    @vexx32
    vexx32 committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    3781f63 View commit details
    Browse the repository at this point in the history

  5. 🐛 (#372) Delay parsing of enum 

    Using a raw scriptblock will break the parser in earlier versions.

Fix is to define it as a string and parse that just before execution.
    @vexx32
    vexx32 committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    91d9f24 View commit details
    Browse the repository at this point in the history