(#376) [Show-Karma] Enable -Contemplate with -Topic #377

vexx32 · 2020-03-10T01:08:07Z

PR Summary

Enables use of -Contemplate with -Topic for Show-Karma

Resolves #376

Added -Topic as an optional parameter to the OpenFile parameter set.
Amended branching logic to ensure that cached topic information is only used if it matches the selected topic, if a topic is selected.
Added test to ensure the correct topic path is passed when a topic is selected.
Amended documentation to clarify that this parameter combination is supported.

Pull Request has a meaningful title.
Summarised changes.
Pull Request is ready to merge & is not WIP.
Added tests / only testable interactively.
- Make sure you add a new test if old tests do not effectively test the code changed.
Added documentation / opened issue to track adding documentation at a later date.

Wildcards are supposed to be supported, so we should expect wildcards.

Required parameters should be shown first, and actually shown as required.

✨ Enable -Contemplate with -Topic

c01db48

vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Module Pertaining to the module's functionality itself. labels Mar 10, 2020

vexx32 requested a review from steviecoaster as a code owner March 10, 2020 01:08

vexx32 added 4 commits March 9, 2020 21:30

✅ add test

ff90ff7

📝 update docs

e66f999

🔧 Correctly compare topic input

e0b94a3

Wildcards are supposed to be supported, so we should expect wildcards.

📝 Adjust params order in documentation

e7561ce

Required parameters should be shown first, and actually shown as required.

vexx32 merged commit 2fd7167 into master Mar 10, 2020

vexx32 deleted the Show-Karma/Topic/AllowContemplate branch March 10, 2020 02:21

vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Mar 10, 2020