Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust typos, parameters, remove unused lines in AboutCsvCmdlets.Koans.ps1 #390

Merged
merged 2 commits into from
May 19, 2020
Merged

Adjust typos, parameters, remove unused lines in AboutCsvCmdlets.Koans.ps1 #390

merged 2 commits into from
May 19, 2020

Conversation

johnheusinger
Copy link
Contributor

@johnheusinger johnheusinger commented May 18, 2020 •
edited

PR Summary

Resolves #389

Context

Made some adjustments to help with issues I had while working through the koan. Fixed typos and parameters, removed unused lines.

Changes

  • Removed references to $Letters and $PipeDelimitedCsvPath which were defined but never used
  • Replaced GetType() with GetType().FullName - The former returns an object, not a string, so the Pester tests would always fail
  • Replaced two instances of Should -NotBeNullOrEmpty with Should -Not -BeNullOrEmpty
  • Issue with failing test due to $CsvString containing type information. Resolved by adding -NoTypeInformation to ConvertTo-Csv

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look! labels May 19, 2020
vexx32
vexx32 approved these changes May 19, 2020
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing these! 💖 😊

@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label May 19, 2020
@vexx32 vexx32 merged commit e40c60a into vexx32:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees
No one assigned
Labels
Category-Koans Invoking the Great Doubt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with AboutCsvCmdlets.Koans.ps1
2 participants
@johnheusinger @vexx32