WIP: Add Redirections #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vexx32
added
PR-Needs-Review 🔍
|
@corbob do you still plan on doing these? 😄 |
vexx32
added
PR-Awaiting-Author ✏️
vexx32
requested changes
Jan 3, 2019
| 2 Error Stream PowerShell 2.0 | ||
| 3 Warning Stream PowerShell 3.0 | ||
| 4 Verbose Stream PowerShell 3.0 | ||
| 5 Debug Stream PowerShell 3.0 |
There was a problem hiding this comment.
These lines need to be standardized in their indentation levels here, it looks like a few of them ended up a little funky. 😄
| $FileContent = Get-Content -Path $FilePath | ||
| '__' | Should -Be $FileContent | ||
|
|
||
| & {Write-Error 'The gasoline is in the water.'} 2> $FilePath |
There was a problem hiding this comment.
A brief comment indicating the reason this is phrased differently would be a good idea, to minimise confusion.
|
Appreciate your work on this, I added some extra comments and put it in #148 💖 |
vexx32
removed
the
PR-Awaiting-Author ✏️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just getting a PR in before I hunker down and make a bunch of work for Issue #24 (ignore that the branch is titled Issue14... apparently I can't computer at 5 AM)