Add mention of negative array indexes in AboutArrays #3
Assignees
Labels
Issue-Enhancement 🎉
Make it better!
Comments
|
Resolved in commit 7fe964b |
vexx32
pushed a commit
that referenced
this issue
Oct 1, 2019
* documented koan order * Documented all proposed changes * Update koanOrder.md * FunExamples and WhatIsDotNet - Created FunExamples Koan - Created WhatIsDotNet Koan. - Having issues abstracting answers for WhatIsDotNet * Added OOP and edited other Koans - Added OOP Koans - Renamed Koans to match naming conventions - Changed AnswerFunction modules to use same template for returning answers - Tested all "drafted" items under koanOrder.md * AboutCmdletVerbs - Created AboutcmdletVerbs Koans module. - Added function help to AboutOOPAnswers and AboutDotNetAnswers - Updated koanORder * Forgot to update koanOrder status - Updated status for AboutCmdletVerbs * Drafted AboutGetMember - Drafted AboutGetMember - Expanded scope of IntroTraining * Drafted AboutBooleans - Drafted AboutBooleans - Changed AboutStrings to use Foundation version rather than IntroTraining * Drafted AboutInts - Drafted AboutInts - Reordered Koans - Next step is AboutBinary * Drafted AboutBinary - Drafted AboutBinary - Made small edits to AboutInts following on from testing * Final draft - Reordered koans - Final draft * Removed conflicting files - Removed conflicting files: PSKoans\Koans\Foundations\AboutTheStockChallenge.Koans.ps1 PSKoans\Koans\Testing Grounds\TestingHashtables.Koans.ps1 - Need to merge PR1. - Then change AboutTheStockChallenge to position 116 * Updated StockChallenge position - Updated StockChallenge position after PR1 merged. * Added line ends - Added line ends to new Koans for CI compatibility * AboutBinary update 01 Updated in-line with PR#241 into PSKoans. * AboutBinary update 02 Updated in-line with PR#241 into PSKoans. * Apply suggestions from code review Applied suggestions from PR#241 review Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * AboutBinary update 03 Updated in-line with PR#241 into PSKoans. * New Line edits Changed VS Code to append line ends on save to all files. * AboutBinary update 04 - Related to PR#241 - Increased indentation of Bit Conversion block - Removed excess E.G. comments * Apply suggestions from code review Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update AboutBinary 05 - Related to PR#241 - Removed references to nibbles - Merged nibble and int blocks into one * Update AboutBinary 06 - Relates to PR #241 - Fixed spelling mistakes * Update AboutBooleans 01 - Related to PR #241 - Minor changes in-line with PR Owner requests * Update AboutBooleans 02 - Relates to PR #241 - Intended comment block for describe booleans * Update AboutCmdletVerbs 01 - Relates to PR #241 - Intended ```It``` blocks and remove "End of" comments - Removed abstraction of answers - Doubled underscores * Update AboutCmdletVerbs 02 - Relates to PR #241 - Added reference to functions - Added reference to Get-Verb - Intended code examples - Remove answer module - Reframed Koans * Update AboutDotNet 01 - Related to PR #241 - Deleted AboutDotNet - Amended koanOrder.md * Update AboutDotNet 02 - Related to PR #241 - Removed AboutDotNetAnswers module as AboutDotNet Koan has been deleted * Update AboutExamples 01 - Related to PR #241 - Removed AboutExamples 01 - Turned Cats/GUI example into Advice JSON - Decided not to port over rickroll example - Amended koanOrder * Update AboutExamples 02 - Related to PR #241 - Reformatted advice JSON files * Update AboutGetMember 01 - Related to PR #241 - Changed comment block title - Changed Get-Service references to Get-Process to make this Joan cross-platform *WIP*: - Added check at end of each It block to make sure user enters unique cmdlets - Removed answer abstraction * Update AboutGetMember 02 - Related to PR #241 - Reformatted Koans - Fixed error with unique count; forget to check the count property rather than whole object - Removed AboutGetMember answer module - Need to fix "Describe" not being picked up when checking Karma - Added line endings to AboutOOPAnswers to hopefully fix CI/CD issues * Update AboutCmdletVerbs 03 - Related to PR #241 - Made minor text changes as per PR review * Update line-ends Hopefully added enough line-ends for CI/CD. Maybe my VS Code is being weird... * Update AboutCmdletVerbs 04 - Related to PR #241 - More minor changes * Update AboutCmdletVerbs 05 - Related to PR #241 - Minor changes * Update AboutCmdletVerbs 06 - Related to PR #241 - Removed 1 line * Update AboutGetMember - Related to PR #241 - Minor changes to formatting * Update AboutInts 01 - Related to PR #241 - Deleted AboutINTs file - Replaced with Numbers advise file * Update AboutNumbers 02 - Related to PR #241 - Recreated AboutNumbers but this time with more basic information - Removed Numbers advise as replaced with AboutNumbers * Update AboutNumbes 03 - Related to PR #241 - Minor UX changes - Updated readme to contain md links * Update KoanOrder 01 - Testing GitHub relative links in markdown * Update KoanOrder 02 - Updated relative links to remove leading ../ * Update KoanOrder 03 - Renamed all intro koans to uppercase K for relative links to work, might need to redo in GitHub GUI - Replaced spaces in markdown to %20, but best practice would be to remove all spaces from file paths * Rename AboutBinary.koans.ps1 to AboutBinary.Koans.ps1 * Rename AboutBooleans.koans.ps1 to AboutBooleans.Koans.ps1 * Rename AboutCmdletVerbs.koans.ps1 to AboutCmdletVerbs.Koans.ps1 * Rename AboutGetMember.koans.ps1 to AboutGetMember.Koans.ps1 * Rename AboutNumbers.koans.ps1 to AboutNumbers.Koans.ps1 * Rename AboutOOP.koans.ps1 to AboutOOP.Koans.ps1 * Update KoanOrder 04 - Renamed broken links * Update AboutOOP - Related to PR #241 - Moved OOP and Answers to drafts - Created advise file for OOP * Update AboutOOP 2 - Related to PR #241 - Renamed IntroTraining to Introduction - Moved AboutAssertions and AboutStrings into Introduction folder - Renamed all references to IntroTraining in koanorder.md - Updated OOPIntrodution.Advice.Json inline with PR comments * Update AboutOOP 3 - Related to PR #241 - Made small changes to advice file * Deleted AboutAsserts - Related to PR #3 - Removed conflicting file to allow for merge * Update AboutAsserts - Related to PR #241 - Removed double space * Rename AboutOOP.Koans.ps1 to AboutOOP.ps1 - Renamed to avoid CI failure due to koan not having int position
thomasrayner
pushed a commit
to thomasrayner/PSKoans
that referenced
this issue
Oct 23, 2019
* documented koan order * Documented all proposed changes * Update koanOrder.md * FunExamples and WhatIsDotNet - Created FunExamples Koan - Created WhatIsDotNet Koan. - Having issues abstracting answers for WhatIsDotNet * Added OOP and edited other Koans - Added OOP Koans - Renamed Koans to match naming conventions - Changed AnswerFunction modules to use same template for returning answers - Tested all "drafted" items under koanOrder.md * AboutCmdletVerbs - Created AboutcmdletVerbs Koans module. - Added function help to AboutOOPAnswers and AboutDotNetAnswers - Updated koanORder * Forgot to update koanOrder status - Updated status for AboutCmdletVerbs * Drafted AboutGetMember - Drafted AboutGetMember - Expanded scope of IntroTraining * Drafted AboutBooleans - Drafted AboutBooleans - Changed AboutStrings to use Foundation version rather than IntroTraining * Drafted AboutInts - Drafted AboutInts - Reordered Koans - Next step is AboutBinary * Drafted AboutBinary - Drafted AboutBinary - Made small edits to AboutInts following on from testing * Final draft - Reordered koans - Final draft * Removed conflicting files - Removed conflicting files: PSKoans\Koans\Foundations\AboutTheStockChallenge.Koans.ps1 PSKoans\Koans\Testing Grounds\TestingHashtables.Koans.ps1 - Need to merge PR1. - Then change AboutTheStockChallenge to position 116 * Updated StockChallenge position - Updated StockChallenge position after PR1 merged. * Added line ends - Added line ends to new Koans for CI compatibility * AboutBinary update 01 Updated in-line with PR#241 into PSKoans. * AboutBinary update 02 Updated in-line with PR#241 into PSKoans. * Apply suggestions from code review Applied suggestions from PR#241 review Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * AboutBinary update 03 Updated in-line with PR#241 into PSKoans. * New Line edits Changed VS Code to append line ends on save to all files. * AboutBinary update 04 - Related to PR#241 - Increased indentation of Bit Conversion block - Removed excess E.G. comments * Apply suggestions from code review Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com> * Update AboutBinary 05 - Related to PR#241 - Removed references to nibbles - Merged nibble and int blocks into one * Update AboutBinary 06 - Relates to PR vexx32#241 - Fixed spelling mistakes * Update AboutBooleans 01 - Related to PR vexx32#241 - Minor changes in-line with PR Owner requests * Update AboutBooleans 02 - Relates to PR vexx32#241 - Intended comment block for describe booleans * Update AboutCmdletVerbs 01 - Relates to PR vexx32#241 - Intended ```It``` blocks and remove "End of" comments - Removed abstraction of answers - Doubled underscores * Update AboutCmdletVerbs 02 - Relates to PR vexx32#241 - Added reference to functions - Added reference to Get-Verb - Intended code examples - Remove answer module - Reframed Koans * Update AboutDotNet 01 - Related to PR vexx32#241 - Deleted AboutDotNet - Amended koanOrder.md * Update AboutDotNet 02 - Related to PR vexx32#241 - Removed AboutDotNetAnswers module as AboutDotNet Koan has been deleted * Update AboutExamples 01 - Related to PR vexx32#241 - Removed AboutExamples 01 - Turned Cats/GUI example into Advice JSON - Decided not to port over rickroll example - Amended koanOrder * Update AboutExamples 02 - Related to PR vexx32#241 - Reformatted advice JSON files * Update AboutGetMember 01 - Related to PR vexx32#241 - Changed comment block title - Changed Get-Service references to Get-Process to make this Joan cross-platform *WIP*: - Added check at end of each It block to make sure user enters unique cmdlets - Removed answer abstraction * Update AboutGetMember 02 - Related to PR vexx32#241 - Reformatted Koans - Fixed error with unique count; forget to check the count property rather than whole object - Removed AboutGetMember answer module - Need to fix "Describe" not being picked up when checking Karma - Added line endings to AboutOOPAnswers to hopefully fix CI/CD issues * Update AboutCmdletVerbs 03 - Related to PR vexx32#241 - Made minor text changes as per PR review * Update line-ends Hopefully added enough line-ends for CI/CD. Maybe my VS Code is being weird... * Update AboutCmdletVerbs 04 - Related to PR vexx32#241 - More minor changes * Update AboutCmdletVerbs 05 - Related to PR vexx32#241 - Minor changes * Update AboutCmdletVerbs 06 - Related to PR vexx32#241 - Removed 1 line * Update AboutGetMember - Related to PR vexx32#241 - Minor changes to formatting * Update AboutInts 01 - Related to PR vexx32#241 - Deleted AboutINTs file - Replaced with Numbers advise file * Update AboutNumbers 02 - Related to PR vexx32#241 - Recreated AboutNumbers but this time with more basic information - Removed Numbers advise as replaced with AboutNumbers * Update AboutNumbes 03 - Related to PR vexx32#241 - Minor UX changes - Updated readme to contain md links * Update KoanOrder 01 - Testing GitHub relative links in markdown * Update KoanOrder 02 - Updated relative links to remove leading ../ * Update KoanOrder 03 - Renamed all intro koans to uppercase K for relative links to work, might need to redo in GitHub GUI - Replaced spaces in markdown to %20, but best practice would be to remove all spaces from file paths * Rename AboutBinary.koans.ps1 to AboutBinary.Koans.ps1 * Rename AboutBooleans.koans.ps1 to AboutBooleans.Koans.ps1 * Rename AboutCmdletVerbs.koans.ps1 to AboutCmdletVerbs.Koans.ps1 * Rename AboutGetMember.koans.ps1 to AboutGetMember.Koans.ps1 * Rename AboutNumbers.koans.ps1 to AboutNumbers.Koans.ps1 * Rename AboutOOP.koans.ps1 to AboutOOP.Koans.ps1 * Update KoanOrder 04 - Renamed broken links * Update AboutOOP - Related to PR vexx32#241 - Moved OOP and Answers to drafts - Created advise file for OOP * Update AboutOOP 2 - Related to PR vexx32#241 - Renamed IntroTraining to Introduction - Moved AboutAssertions and AboutStrings into Introduction folder - Renamed all references to IntroTraining in koanorder.md - Updated OOPIntrodution.Advice.Json inline with PR comments * Update AboutOOP 3 - Related to PR vexx32#241 - Made small changes to advice file * Deleted AboutAsserts - Related to PR vexx32#3 - Removed conflicting file to allow for merge * Update AboutAsserts - Related to PR vexx32#241 - Removed double space * Rename AboutOOP.Koans.ps1 to AboutOOP.ps1 - Renamed to avoid CI failure due to koan not having int position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See title. Looks like I overlooked it, oops.
The text was updated successfully, but these errors were encountered: