Skip to content

Commit

Permalink
rfbproto: fix broken endianess handling on Win32
Browse files Browse the repository at this point in the history
It's definitely wrong to build with LIBVNCSERVER_WORDS_BIGENDIAN
defined on Win32. Instead use the auto-detected endianess macro
(which will indicate little endian on i686/x86_64). Removing the
hardcoded define makes all tests pass (especially encodingtest)
when built with MinGW64 toolchain.

In combination with PR LibVNC#257 this fixes issues LibVNC#165 and LibVNC#249.
  • Loading branch information
tobydox committed Dec 5, 2019
1 parent a9f95d8 commit b99afa0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion rfb/rfbproto.h
Expand Up @@ -63,7 +63,6 @@
#include <stdint.h>

#if defined(WIN32) && !defined(__MINGW32__)
#define LIBVNCSERVER_WORDS_BIGENDIAN
typedef int8_t rfbBool;
#include <sys/timeb.h>
#include <winsock2.h>
Expand Down

0 comments on commit b99afa0

Please sign in to comment.