Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] unused metadata PatchSet? #4

Closed
sanzoghenzo opened this issue Nov 7, 2023 · 1 comment
Closed

[question] unused metadata PatchSet? #4

sanzoghenzo opened this issue Nov 7, 2023 · 1 comment

Comments

@sanzoghenzo
Copy link

Hi @vfarcic, thanks for your great work in spreading k8s and gitops knowledge!

I was wondering why there's a PatchSet named metadata in all your compositions, but it is never used/called in the actual patch (even more so now that you switched to functions).

From what I can read in the documentation, PatchSets would only be applied to resources that include them using type: PatchSet and name: metadata in the patches, but there's no such thing anywhere in your compositions.

Am I reading the documentation wrong, or the metadata PatchSet is unused/useless?

@vfarcic
Copy link
Owner

vfarcic commented Nov 7, 2023

You're absolutely right. It should not be there. It's a leftover from the early versions of that Configuration. I just removed it.

@vfarcic vfarcic closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants