Manage username and password with Docker Secrets #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 21, 2017 17:58
Apparently 3.4 gives an nullpointer when not specifying -sslFingerprints with a value
|
Brilliant! Thank you. |
|
Can you make a new PR on a separate branch? This one is great but it is not backward compatible so I had to roll it back. I'll push a new image from that branch with a different tag so that both coexist for a while. |
|
Will do, was a bit short-sighted to make a secrets only version. My apologies for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming we only use this in an Docker Swarm cluster only.
If thats not the case, maybe this should be a separate branch so there's a separate tag for this usecase.
Updated the client version to 3.3, as it has some good improvements over 2.2.
For me 3.4 didn't work without the -sslFingerprints tags, so kept it at 3.3.