Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My PR2 #149

Closed
wants to merge 4 commits into from
Closed

My PR2 #149

wants to merge 4 commits into from

Conversation

bfarhad
Copy link

@bfarhad bfarhad commented Oct 2, 2019

No description provided.

@vfarcic
Copy link
Owner

vfarcic commented Oct 2, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vfarcic

If they are not already assigned, you can assign the PR to them by writing /assign @vfarcic in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vfarcic
Copy link
Owner

vfarcic commented Oct 2, 2019

Hi @bfarhad. Thanks for your PR.

I'm waiting for a vfarcic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vfarcic vfarcic added the size/XS label Oct 2, 2019
@vfarcic vfarcic added size/S and removed size/XS labels Oct 2, 2019
@vfarcic vfarcic closed this Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants