This repository has been archived by the owner on Apr 8, 2018. It is now read-only.
Implemented method to get stream from IP cameras using user and passw… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay in responding. I'd be more inclined to offer a configuration block for doing modifications to the HTTP Header fields than having these classes concerned with making modifications to the headers. Additionally, I wouldn't want to have some of the header fields - such as user agent string - hard coded. If you want to make such modifications and submit a new PR I'll gladly accept it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to change your code to use with IP CAM with user and password.
Let me know with you agree with the code.
thks.