Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all exceptions from cppmm are handled #27

Open
scott-wilson opened this issue May 29, 2021 · 0 comments
Open

Make sure all exceptions from cppmm are handled #27

scott-wilson opened this issue May 29, 2021 · 0 comments

Comments

@scott-wilson
Copy link
Member

We ran into an issue yesterday where an error wasn't handled in the safe API, causing a segfault. In order to avoid those for now, we should make sure that all functions from cppmm are handled. Even if it is just sys::Imf_func(...).into_result().unwrap().

The PR template should be updated to include that as a requirement for accepting a PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant