Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching ignores data type #2

Closed
vgXhc opened this issue Mar 26, 2023 · 0 comments
Closed

Caching ignores data type #2

vgXhc opened this issue Mar 26, 2023 · 0 comments
Assignees
@vgXhc
Labels
bug Something isn't working

Comments

@vgXhc
Copy link
Owner

vgXhc commented Mar 26, 2023

The cache= function appears to be broken and leads to incorrect results. A get_ntd(data_type = "adjusted", cache = TRUE) call followed by get_ntd(data_type = "raw", cache = TRUE) leads to no downloading of the correct file in the second call. Probably the checking of an existing downloaded file function is too general and doesn't distinguish between raw and adjusted data.
@vgXhc vgXhc added the bug Something isn't working label Mar 26, 2023
@vgXhc vgXhc self-assigned this Mar 26, 2023
vgXhc added a commit that referenced this issue Mar 26, 2023
@vgXhc
fixing cache function (#2)
5222e47
@vgXhc vgXhc closed this as completed Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vgXhc vgXhc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vgXhc