-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple formatters. #27
Conversation
options.format = 'pretty'; | ||
} | ||
|
||
var formats = util.isArray(options.format) ? options.format : [options.format]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like util.isArray
is deprecated and should be replaced to Array.isArray
now. https://nodejs.org/api/util.html#util_util_isarray_object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just following the existing code right below this dealing with multiple tags. I can update it if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that was because of someone's PR but please, take a look at this comment #27 (comment)
Hi! Seems like cucumber.js doesn't support multiple formatters https://github.com/cucumber/cucumber-js#formatters
Cucumber.js used the last one from the array. |
They have supported passing multiple formats since 0.8.0. This change is needed when you want to output json to a file when running in a ci environment and also display it to the console. We've been using it successfully this way since I opened the pr. |
Oh, sorry for misunderstanding you and thanks for the explanation. |
Support for multiple formatters.
Cool, thanks! |
No description provided.