Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panicked job calls hook job done with typed error #249

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

vgarvardt
Copy link
Owner

addresses #247

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (caf8aaa) 89.54% compared to head (beb5352) 89.43%.

Files Patch % Lines
worker.go 80.00% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   89.54%   89.43%   -0.12%     
==========================================
  Files          12       12              
  Lines         727      757      +30     
==========================================
+ Hits          651      677      +26     
- Misses         56       59       +3     
- Partials       20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgarvardt vgarvardt marked this pull request as ready for review December 28, 2023 16:56
@vgarvardt vgarvardt merged commit ad854e2 into master Dec 28, 2023
10 of 12 checks passed
@vgarvardt vgarvardt deleted the fix/panic-calls-hook-job-done branch December 28, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant