Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hexview feature parity #237

Merged
merged 7 commits into from
Aug 22, 2021
Merged

Hexview feature parity #237

merged 7 commits into from
Aug 22, 2021

Conversation

DubiousDoggo
Copy link
Contributor

Description

  • QHexDocument reads directly from the VGMFile
  • Moved some functionality from QHexDocument and QHexCursor into QHexView
  • Selected events in the tree view are highlighted in the hexview, bold with red outline, and visa versa
  • Updated font

How Has This Been Tested?

  • General UI stress testing

Screenshots:

  • Container selection from tree view
    image

  • Multi line selection
    image

  • Contiguous Area
    image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.

@sykhro sykhro changed the title Hex View Rework Hexview feature parity Aug 18, 2021
@sykhro sykhro added this to In progress in Qt frontend via automation Aug 18, 2021
Copy link
Member

@sykhro sykhro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good overall, please remember to squash the fixup commits.

src/ui/qt/util/Helpers.cpp Show resolved Hide resolved
src/ui/qt/workarea/VGMFileTreeView.h Show resolved Hide resolved
src/ui/qt/workarea/qhexview/document/qhexcursor.h Outdated Show resolved Hide resolved
src/ui/qt/workarea/qhexview/document/qhexdocument.cpp Outdated Show resolved Hide resolved
Copy link
Member

@sykhro sykhro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are fine but they should be squashed onto their original commits (commit message says "remove dead code" but actually does a whole lot more).

@sykhro sykhro merged commit 18997b2 into vgmtrans:master Aug 22, 2021
Qt frontend automation moved this from In progress to Done Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Qt frontend
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants