Fix: VAB parsing 1 too many instruments #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically this can overflow. I'm not sure if it has practical effects, but this fixes it.
The previous example would parse N+1 instruments, when only N exist.
|
Please take a look. When the number of instruments was 1, the code would parse first the 0 offset, then the 1 offset. But instrument 1 doesn't exist. This probably wouldn't cause too many problems, but if there was 512 instruments used, this would seemingly start doing some wacky things. |
loveemu
requested changes
Jan 26, 2022
loveemu
approved these changes
Jan 27, 2022
Co-authored-by: loveemu <loveemu@gmail.com>
Co-authored-by: loveemu <loveemu@gmail.com>
|
@sykhro I have approved the pull request. There are several merge strategies to choose from, do you have any recommendations? |
|
I'm okay with anything but squashing. Perhaps we can go for rebase & merge, up to you. Whatever we end up choosing it should probably become the default from now on |
mikelow
pushed a commit
that referenced
this pull request
Jul 16, 2023
Fix: VAB parsing 1 too many instruments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: I changed this from a nit, to an actual bug fix.