FreeBSD does not pass tests

[benrubson]

Hi,

# uname -sr
FreeBSD 11.0-RELEASE-p7

# ./build/encfs --version
encfs version 1.9.1

# ./test.sh 
+ '[' '!' -d build ']'
+ perl -MTest::Harness -e '$$Test::Harness::verbose=1; runtests @ARGV;' tests/normal.t.pl tests/reverse.t.pl
tests/normal.t.pl ... 54/104 
#   Failed test 'corrupted file with MAC returns read error: '
#   at tests/normal.t.pl line 80.
tests/normal.t.pl ... 58/104 # Looks like you failed 1 test of 104.
tests/normal.t.pl ... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/104 subtests 
	(less 2 skipped subtests: 101 okay)
tests/reverse.t.pl .. 3/26 
#   Failed test 'ciphertext and decrypted size of file grown to 10 bytes'
#   at tests/reverse.t.pl line 131.
tests/reverse.t.pl .. 9/26 
#   Failed test 'decrypted files are identical'
#   at tests/reverse.t.pl line 72.
tests/reverse.t.pl .. 22/26 # Looks like you failed 2 tests of 26.
tests/reverse.t.pl .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/26 subtests 

Test Summary Report
-------------------
tests/normal.t.pl (Wstat: 256 Tests: 104 Failed: 1)
  Failed test:  56
  Non-zero exit status: 1
tests/reverse.t.pl (Wstat: 512 Tests: 26 Failed: 2)
  Failed tests:  8, 12
  Non-zero exit status: 2
Files=2, Tests=130, 16 wallclock secs ( 0.04 usr  0.00 sys + 14.97 cusr  0.45 csys = 15.45 CPU)
Result: FAIL
Failed 2/2 test programs. 3/130 subtests failed.

Of course underlying FS is ZFS.
But results are the same using a tmpfs.

@enodata perhaps you noticed this maintaining FreeBSD encfs port ?

Thank you 👍

Ben

[benrubson]

1/2

Normal test fails because of this :

From https://github.com/freebsd/freebsd/blob/stable/11/sys/fs/fuse/fuse_kernel.h#L117 :
FOPEN_KEEP_CACHE: don't invalidate the data cache on open

However FOPEN_KEEP_CACHE does not seem to be implemented at all :
https://github.com/freebsd/freebsd/blob/stable/11/sys/fs/fuse/fuse_node.c#L270

Adding the following in FreeBSD fuse code corrects the issue :

if (!(fuse_open_flags & FOPEN_KEEP_CACHE)) {
	fuse_io_invalbuf(vp, td);
}

As a workaround here you should mount with -o direct_io which internally calls fuse_io_invalbuf().

FreeBSD bug opened :
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218636
Now closed and committed to stable/11 :
freebsd/freebsd-src@2a1d90c

[benrubson]

2/2

#   Failed test 'ciphertext and decrypted size of file grown to 10 bytes'
#   at integration/reverse.t.pl line 193.

This is the concerned code :

    my $max = 9000;
    for($i=5; $i < $max; $i += 5)
    {
        print($pfh "abcde") or die("write failed");
        # autoflush should make sure the write goes to the kernel
        # immediately. Just to be sure, check it here.
        sizeVerify($vfh, $i) or die("unexpected plain file size");
        sizeVerify($cfh, $i) or $ok = 0;
        sizeVerify($dfh, $i) or $ok = 0;

        if(md5fh($vfh) ne md5fh($dfh))
        {
            $ok = 0;
            print("# content is different, unified diff:\n");
            system("diff -u $plain/grow $decrypted/grow");
        }

        last unless $ok;
    }
    ok($ok, "ciphertext and decrypted size of file grown to $i bytes");

After having verified, test fails because of the 2 sizeVerify calls (which set $ok to 0).
FreeBSD bug opened (and now closed) for attributes caching issue :
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230258
And here is the FreeBSD bug opened (corrected but not merged yet) for invalid cached contents :
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235774

As of FreeBSD 12.1, file size is now OK, but content is not (the md5 test).
Discussed here : https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244178
Patch merged : freebsd/freebsd-src@cf19591

[asomers]

FYI the entry_timeout and attr_timeout are fully supported in the projects/fuse2 branch, and should be available in the (not yet released) 13.0 and 12.1 releases.

[benrubson]

Really good news @asomers, thank you very much !
Though I think the invalid cached contents issue was the main issue, which you solved there :
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235774
I then assume you defaulted entry_timeout and attr_timeout to 0 ?
Many thanks again 👍

[asomers]

Actually, the default for entry_timeout and attr_timeout is set in libfuse, not in the kernel. The default is 1 second.