Unmount improvements #507
Merged
Unmount improvements #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfjakob
requested changes
Apr 8, 2018
encfs/FileUtils.cpp
Outdated
| wait(&status); | ||
| if ((pid = fork()) == 0) { | ||
| execl("/usr/bin/pkill", "/usr/bin/pkill", "-INT", "-f", string("(^|/)encfs .*/.* ").append(mountPoint).append("?( |$)").c_str(), (char *)0); | ||
| _Exit(127); |
There was a problem hiding this comment.
Code after execl is never reached!
There was a problem hiding this comment.
Yep but this is to make the child to exit if execl fails 👍
There was a problem hiding this comment.
Good point. But shouldn't we print an error message in that case?
There was a problem hiding this comment.
Yep, improved with log messages !
|
I've just improved commit message. |
Log OSX unmount system error Better handle Cygwin unmount child Use WinFsp expected INT signal
rfjakob
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I would have liked to keep some things from #503, so, this PR :
INTsignal expected by WinFsp rather than defaultTERM.Thank you !
Ben