Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing #2 #747

Merged
merged 2 commits into from Oct 5, 2023
Merged

Improve typing #2 #747

merged 2 commits into from Oct 5, 2023

Conversation

kellerza
Copy link
Contributor

@kellerza kellerza commented Oct 4, 2023 •
edited

This fixes a circular import of GraphClient introduced by #746

It was supposed to be part of #746,- but I likely missed the git push.

Is ClientRunTimeContext, ClientContext or GraphClient the intended type for context?

@vgrem
Copy link
Owner

vgrem commented Oct 4, 2023

It is expected to be GraphClient since the base type for Microsoft Graph entities.

@kellerza
Copy link
Contributor Author

kellerza commented Oct 5, 2023

Ok, changed it to GraphClient and used TYPE_CHECKING to prevent the circular import error

Thanks for applying Black!

@kellerza
Copy link
Contributor Author

kellerza commented Oct 5, 2023

flake8 seem ok in the latest CI run, but lots of work to fix pylint

@vgrem vgrem merged commit abbdb75 into vgrem:master Oct 5, 2023
1 check failed
@kellerza kellerza mentioned this pull request Oct 5, 2023
Open
@kellerza kellerza deleted the typing branch October 5, 2023 07:03
@kellerza kellerza restored the typing branch October 5, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kellerza @vgrem