Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box Changes (Tradepost, Satellite, misc) #12623

Merged
merged 9 commits into from
Dec 4, 2016
Merged

Box Changes (Tradepost, Satellite, misc) #12623

merged 9 commits into from
Dec 4, 2016

Conversation

Probe1
Copy link
Member

@Probe1 Probe1 commented Nov 29, 2016

I consider this PR complete and ready for review.

Fixes
Fixes Vox Raider ship not lining up with the dock #12623 (comment)
Removes errant /obj/ from paramedic locker.

Additions
Increases trays in Trade Outpost to 22. Adds xenobot machines and farmbot. #12623 (comment)
Adds Trader Access requirement to specific Vox Tradepost doors. The armory and vault areas as well as the external door facing the asteroid will require Vox Trader access. The rest will have no requirements. #12623 (comment) Compliments restricted doors with Rwalls #12623 (comment)
Varies the syringes in Box Security Medbay from 3 inaprovaline to 1 charcoal, 1 anti tox, 1 inaprovaline, and throws in a bottle of happy pills (Space drugs + Sugar) for good measure #12002
Unifies Paramedic Morgue access

Removals
Removes Cyber Horrors from satellite, replaces with Russians #12623 (comment)

Closes #12047
Closes #11847
Closes #11380
Closes #10992
Closes #12509

🆑

  • rscadd: Box Vox Post now has more trays, a farmbot, xenobotany machines, and bees. High value rooms have been given vox trader access requirements.
  • tweak: Box brig medical now has anti toxin and charcoal syringes.
  • tweak: Box Paramedics can now enter the morgue from any door.
  • rscdel: Cyber horrors on Goonsat have been replaced with Russians
  • bugfix: Vox Raider ship aligns better with Vox Outpost.

(Box) Adds Trader Access requirement to interior Vox Tradepost doors.
@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

dreammaker_2016-11-29_09-12-41

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

Custom vote started by Kavlax.
#11847 Should the Vox Outpost airlocks require Vox Trader access?
Type vote to place your votes.
You have 60 seconds to vote.

Vote Result: Yes with 7 votes
No had 3 votes

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

The same way it works for the trade shuttle. It's an electromagnetic ID card.

@jakmak3
Copy link
Contributor

jakmak3 commented Nov 29, 2016

ok for the trader access while it does make sense from a balance standpoint it makes no sense from a lore standpoint since the trader ID's are simply just passports to keep them from being lynched

As for russians i do support removing the cyberhorrors of doom but russians had the problem is being easy as hell to cheese. What if they had spacesuits on them OR what if instead of russians they are replaced with nazis with nazi hardsuits?

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

If you code up that mob for me then yes, I will add it.

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

image

Working out the rough shape for the reinvorgation of the Box Outpost #11380

Too many trays right now.

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

Yes I could but I'm trying to focus on the existing issues that haven't been responded to and this is a detour.

It's not that I dislike the idea or think you're in the wrong. It's that I have to manage my time or I won't be able to map the stuff you like too.

@jakmak3 That would result in the station getting a bunch of very high end hardsuits at will. It's even better loot rather than an even better challenge.

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

You're making a suggestion. One I'm fine with but not one that was directly raised in an issue that I am seeking to close. If we pursued that then mid-PR people would start debating whether or not we should have stronger Russians instead of the original agreed upon idea that cyber horrors were a bad fit and the original mobs should return.

Please note the first PR to address this months ago was closed due to this kind of mid development debate.

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

I'm all for it but we'll have to tackle one issue at a time. And right now I want to tackle a bunch of issues!

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

Old

image

New

image

@Shadowmech88
Copy link
Contributor

The two trays aligned diagonally in the middle-west of the room look kind of out of place.

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

Really? I thought it gave the room a detailed aesthetic
dreamseeker_2016-11-29_10-19-08
.

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

Oh yeah bees

@Shadowmech88
Copy link
Contributor

It's just my opinion, but I think it'd look better if it was a square of four trays.

@kilozombie
Copy link
Contributor

I think the interior doors should stay zero-access. After all, with such a huge botany, I'm gonna have to recruit people to help me out!

@jknpj
Copy link
Collaborator

jknpj commented Nov 29, 2016

@kilozombie
That sounds like a job for our native plant men!

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

Not a big fan. Maybe on the entrance doors, but once people are inside it should be free reign IMO.

How is this compromise on Trader door Access?

Only the set of doors that lead you into the station require access

@kilozombie
Copy link
Contributor

Pretty good compromise! It makes sense that traders would have to let people in, unless they feel like breaking windows.

Also, 2 side things:

  1. With the botany extension, the leftmost airlock is still just BARELY too far to the right to avoid the metal girders above, and therefore anything spaced will be caught by it. In some ways, this is a great thing, unless you have a lot of corpses for some reason.
  2. That 36-tray botany is complete insanity. Bedlam. The power is nigh-incomprehensible.

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

The submitted changes are 22 trays + bees, xenobotany, and a farmbot. The 36 was getting carried away making something I enjoyed.

I will alter the lattice*.

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

Custom vote started by Diethyl.
Should the Vox Outpost airlocks require Vox Trader access?
Type vote to place your votes.
You have 60 seconds to vote.

Vote Result: No with 8 votes
Yes had 6 votes

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

dreammaker_2016-11-29_10-51-14

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

I know it's ugly but it's the best I can do.

@AI-Is-Rogue
Copy link
Contributor

Won't it suck nitrogen out of the Skipjack and ZAS the raiders with their boots off?

@kilozombie
Copy link
Contributor

I enjoy botany a bit too, and the 36 tray, while ridiculous, also looked pretty great, so commendations all around.
Also, the dock ALREADY does that. There's an empty space tile between the skipjack and the airlock, and anyone without their magboots on will take a mean blow to the face.

@AI-Is-Rogue
Copy link
Contributor

I know there is a space tile there, but Probe put a catwalk in that spot and I think it should just be replaced with a regular floor to minimize nitrogen leaking and raiders getting thrown about.

@kilozombie
Copy link
Contributor

Ah, alright.

@Probe1
Copy link
Member Author

Probe1 commented Nov 29, 2016

The reward was the item they were guarding. Now the rewards a mateba, a hardsuit, an egun, etc.

The real reward is just killing the guys. That really screws up the priority for designers.

@jknpj
Copy link
Collaborator

jknpj commented Nov 29, 2016

The real reward is the space adventure. Maybe make them yell and explode(not like the nuke ops, maybe something fluffy like the roid's locked crates) when they die for muh immulsions if they are going to disappear when dead.

@Sprok0
Copy link
Contributor

Sprok0 commented Nov 29, 2016

The goonecode was worthless because the satellite was so easy to clear, bringing the russians back just makes it even easier to cheese and devalues it further.

@Sprok0
Copy link
Contributor

Sprok0 commented Nov 29, 2016

No, you just need a few sheets of metal to make dislodged girders/computer frames/any movable solid object to block the lasers, move past the two left turrets and disable the APC. The entire thing is a joke if you have even a fraction of a brain.

@Sprok0
Copy link
Contributor

Sprok0 commented Nov 29, 2016

A stack of metal and a toolbelt aren't what I'd call "so prepared", that's pretty basic stuff that anyone can get at roundstart. There is no challenge or difficulty in getting to the goonecode if you know how to do it, which is what makes it worthless.

@Sprok0
Copy link
Contributor

Sprok0 commented Nov 29, 2016

Who's talking about captains? An assistant can do it after stealing a suit from EVA/making a ghetto rig

@PJB3005 PJB3005 added the Mapping (Box 👶) Box map touched. label Nov 30, 2016
@Durgen
Copy link
Contributor

Durgen commented Nov 30, 2016

once upon a time kurfurst made a pull for an outpost redesign that was well received
#11441
his included vox access on all the doors, (which wasn't deemed a problem at the time)
it also got rid of the very long and ugly hallway leading from the docks to the outpost proper

edit: we should have replaced the gooncode item with a pomfcoin months ago when the leak happened

@Intigracy
Copy link
Contributor

If you think the way you handled the skipjack is ugly, take a look at the way one of the other maps do it.

It's the airlock moved down one tile.

@Intigracy
Copy link
Contributor

actually your own image in your other PR shows how it's done:

d11ccc6a-b565-11e6-81aa-8efb249289ad

@Probe1
Copy link
Member Author

Probe1 commented Nov 30, 2016

Yeah but I view that solution as even worse @Intigracy

@jknpj
Copy link
Collaborator

jknpj commented Nov 30, 2016

Remember to add conveyors and air flaps if you're going to use cycling airlocks, because transporting things through cycling airlocks can be a real pain in the beak

@Probe1
Copy link
Member Author

Probe1 commented Nov 30, 2016

Then people will just use the conveyor to enter 🍆

@Blithering
Copy link
Contributor

Can the goonecode be replaced with a pomfcoin to bring back it's value?

@Probe1
Copy link
Member Author

Probe1 commented Dec 1, 2016

That would not bring back its value.

Players ran it into the ground. We are the monsters.

@Exxion
Copy link
Member

Exxion commented Dec 1, 2016

Ostensibly, the reason it has no value is that the actual Gooncode was leaked

@Shadowmech88
Copy link
Contributor

There was an idea to replace it with 2 Bitcoins in reference to the leaker's extortion of one of the Goon coders.

@Probe1
Copy link
Member Author

Probe1 commented Dec 1, 2016

I was referring to the ephemeral nature of the challenge. After the first month, the sat is figured out and there's nothing particularly noteworthy or special about retrieving it so it's difficult to reward players with a grand wish when they were not challenged to earn it.

Also changing the sat every so often proved untenable since it was suggested and no one was willing to do that at all, let alone regularly.

@Shadowmech88
Copy link
Contributor

It'd be less easy to game the sat if our mobs were more intelligent, making them harder to cheese in combat.
I took a whack at trying to refactor mob intelligence into mind datums instead of it all being tied to the mob's Life(), but I couldn't muster the drive to get very far.

@Probe1
Copy link
Member Author

Probe1 commented Dec 1, 2016

Thats the long and short of it alright.

Its a big ol pile of stuff to do with few takers.

@Sprok0
Copy link
Contributor

Sprok0 commented Dec 2, 2016

While you're touching the satellite, I'd make the double windows on the walkways into a single stronger window on the outside, the windows on the same tile as the floor block mobs and absorb the turret laser shots

@Kurfursten
Copy link
Collaborator

I think it's crazy to rework the Vox outpost but keep the giraffe hallway and the poisonous trading floor no one uses now that we have ships. On the other hand, you are making things marginally better in the mean time, and someone may come along later and fix the outpost once and for all - so it doesn't hurt to have a better outpost in the interim.

@Probe1
Copy link
Member Author

Probe1 commented Dec 3, 2016

I am a marginal kind of guy. I like to see things merged instead of in "I'll finish this later" hell like my asteroid station.

I agree that it would be cool to have a new vox station, and I really liked yours, but I'm satisfied with what I've done.

@Sprok0 I saw your post but I'm really dying to get this merged so I can move on from the changes already made.

@Intigracy Intigracy merged commit e6659cf into vgstation-coders:Bleeding-Edge Dec 4, 2016
@Probe1 Probe1 deleted the Box_Changes_11_29 branch December 4, 2016 19:42
@kilozombie
Copy link
Contributor

Hurrah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping (Box 👶) Box map touched.
Projects
None yet