Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XGM #14609

Closed
wants to merge 12 commits into from
Closed

XGM #14609

wants to merge 12 commits into from

Conversation

PJB3005
Copy link
Contributor

@PJB3005 PJB3005 commented Apr 8, 2017 •
edited

So last year in August, me and @clusterfack started this. We lost steam and forgot about it. To not lose steam this time I'm just gonna make the PR so people can shout when.

I'm reviving this now, but it's still very WiP and in no way merge ready.

I lost the commit history due a Git issue, see here for the history: https://github.com/vgstation-coders/vgstation13/tree/XGM

Checklist:

  • #warn TODOs need to be fixed.
  • Zone regen has bug where sprites get lost for a tick.
  • Fire needs balancing.
  • Update with latest fixes from bay.
  • Make plasma not ignite below visibility.

@PJB3005
Update WiP XGM back into Bleeding-Edge.
ed657ae 
Commits were losts because git history broke.
@PJB3005
It compiles!
f7dcd6a
@PJB3005 PJB3005 added Port Stolen/Ported from another codebase. System Modifies an underlying system within the game, may not affect players in any way. ⚠️ OH GOD IT'S LOOSE ⚠️ Well shit. ✋ Do Not Merge ✋ Don't you do it. labels Apr 8, 2017
@JustSumBody
Copy link
Contributor

remind me what all XGM does special?
I remember there's the whole "fires melt walls" dealio and MULTIZAS, but other than that what does it do

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 8, 2017

Actually this is too old for multiZAS but porting MultiZAS will become easier at least.

@ghost
Copy link

ghost commented Apr 9, 2017 •
edited by ghost

holy
fuck

also what is multizas

@Anton-Kr
Copy link
Contributor

Anton-Kr commented Apr 9, 2017

@unusualcrow Working ZAS on multi-z stations.

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 9, 2017

Nevermind actually I think this does include multiZAS somewhat.

@Exxion
Copy link
Member

Exxion commented Apr 9, 2017 •
edited

Even our current ZAS includes multiZAS
There's a define to enable it
#define ZLEVELS

It almost definitely doesn't work properly, but it's there

@FudgePucker
Copy link
Contributor

I guess multi-zas could lead to some away mission fun.

What other possible changes would this system provide?

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 9, 2017

Bugfixes, better performance, meme gases with basically zero cost, fun fires, Wall melting.

@gbasood
Copy link
Contributor

gbasood commented Apr 9, 2017

Gas datums

@Fruktlimpa
Copy link
Contributor

Wall melting. At what temperature are we talking here and how fast will the walls melt? I can imagine it could get overwhelming.

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 10, 2017

No idea fight now and it's probably gonna need balancing for engineering.

@Fruktlimpa
Copy link
Contributor

Sounds really neat in any case.

@Shadowmech88
Copy link
Contributor

What exactly is this? A new atmos system?

What all does it do differently?

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 10, 2017

It's just updating everything to (almost) latest bay.

@Shadowmech88
Copy link
Contributor

So what all will it do differently?
I know nothing of current Bay atmos.

@Exxion
Copy link
Member

Exxion commented Apr 10, 2017

For one, datumized gases
I haven't read the code, but I assume they're singleton datums defining types of gases, rather than an individual datum for each instance of a gas in a zone, for performance reasons
The latter... didn't work very well when we tried it

*shudder

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 11, 2017

Yeah they're just singletons.

@ComicIronic
Copy link
Contributor

We never tried new datum instances for every gas instances. The previous version also used singletons - it performed badly for different reasons.

@Exxion
Copy link
Member

Exxion commented Apr 11, 2017

Oh
Well never mind

Probe1
Probe1 reviewed Apr 13, 2017
View reviewed changes
__DEFINES/atmos.dm

#define MARS_ATMOSPHERE 0.6 //kPa
#define CO2MARS 0.96
#define N2MARS 0.04 //Mars atmosphere is actually 1.9% nitrogen, 1.9% argon with traces of other gases. Simplified to 4% nitrogen
Copy link
Member

@Probe1 Probe1 Apr 13, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have separate defines for Mars? (This goes for all the defines but I'm not going to clutter up every line below)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some turfs use mars atmosphere

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of the vaults uses mars atmosphere

@mtpowell
Copy link
Contributor

This looks amazing, how does the TEG burn room hold up and the SME? Does it act on pressure?

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 16, 2017

Wall melting and window breaking only happens from fires, probably for performance. Melting temperature of reinforced walls is literally infinite and I'm gonna make plasma glass not break either.

I want to remind you that windows not breaking previously from fire was a bug.

@Exxion
Copy link
Member

Exxion commented Apr 16, 2017 •
edited

Windows do break from pressure
But only from the pressure on their own tile, rather than the differential across them

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 16, 2017

@Exxion pretty sure they only break from fire, and XGM fixes the same tile issue with it.

@Exxion
Copy link
Member

Exxion commented Apr 16, 2017

Let me rephrase that
When they break, it's due to a pressure check
I don't remember whether or not that check is only performed if there's fire there, though

@Shadowmech88
Copy link
Contributor

Is there any kind of remotely realistic reason why a material would only melt when exposed to flame rather than temperature?
Or are we just going to have to ignore the inconsistency?

@Exxion
Copy link
Member

Exxion commented Apr 16, 2017

Performance

@Shadowmech88
Copy link
Contributor

I get why it's necessary but when possible I still like to have even thinly-constructed in-universe reasons for why it could happen.

@Exxion
Copy link
Member

Exxion commented Apr 16, 2017

Oxidation

@BlueNexus
Copy link
Contributor

You'll need to port the MultiZAS changes as well, your version is way too old to work properly.

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 17, 2017

I couldn't find any significant changes to ZAS since when we started this, though I'll look again.

@BlueNexus
Copy link
Contributor

BlueNexus commented Apr 17, 2017 •
edited

Baystation12/Baystation12#14538
Baystation12/Baystation12#14558
Baystation12/Baystation12#14927
Baystation12/Baystation12#14957
@PJB3005 You'll need all of these for MultiZAS to work properly. Comment or uncomment the #define MultiZAS flag at your discretion.

@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 17, 2017

@BlueNexus alright, I'll port em, thanks!

@BlueNexus
Copy link
Contributor

BlueNexus commented Apr 17, 2017 •
edited

Oh, this too - Baystation12/Baystation12#14225
Port that one first. Sorry, I forgot about that one. (And, no problem. 😄 )

@PJB3005 PJB3005 closed this Apr 23, 2017
@BobdaBiscuit
Copy link
Contributor

RIP

@BlueNexus
Copy link
Contributor

RIP

Why, if I may ask?

@Exxion
Copy link
Member

Exxion commented Apr 23, 2017

Not again

@gbasood
Copy link
Contributor

gbasood commented Apr 23, 2017

drama
possibly revived later

@Exxion
Copy link
Member

Exxion commented Apr 23, 2017

I'm going to set literally everything that has ever existed or will ever exist on fire
Why does everything go to shit roughly once a month?

@PJB3005 PJB3005 reopened this Apr 23, 2017
@PJB3005
Copy link
Contributor Author

PJB3005 commented Apr 23, 2017

@Exxion I think you know the answer.

@Exxion
Copy link
Member

Exxion commented Apr 23, 2017

the

There isn't only one

@FudgePucker
Copy link
Contributor

I don't know what happened so I will just guess what happened.
Discord was a mistake.

@gbasood
Copy link
Contributor

gbasood commented Apr 28, 2017

wrong

@PJB3005 PJB3005 closed this May 27, 2017
@Zth-- Zth-- deleted the XGM_new branch May 4, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Probe1 Probe1 Probe1 left review comments

@unid15 unid15 unid15 left review comments

Assignees
No one assigned
Labels
✋ Do Not Merge ✋ Don't you do it. ⚠️ OH GOD IT'S LOOSE ⚠️ Well shit. Port Stolen/Ported from another codebase. System Modifies an underlying system within the game, may not affect players in any way.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet