Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalances black and green core reactions also adds three items to green cores (fug) #14649

Merged
merged 14 commits into from Apr 23, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2017

well the green slime core had a bunch of medicine you could get if you had access to a chem dispenser which is required to do those reaction? Seemed kinda useless so i removed the medicine reactions from green and put DD, rezadone, and peridoxin to the black core
Black cores now give 5u nanobots instead of 1u combat or 1u medical
i'll probably add some unique xenobio items to the green core later like a slime heart that needs to be coded and sprited and slime tiles
I'll probably include that in another PR that adds reactions to pyrite and sepia as well as excluding xenos from gold cores but right now i want to see what people think about this
"when you code it" they said
Update: raincoat will be replaced by a special yellow raincoat
Update: yellow raincoat replaced with slime coat that works like a wintercoat that looks like a yellow raincoat
image
fuck my life the raincoat will be hell to code BUT I GOTTA DO IT
image
TO DO:
NADA
🆑

  • rscadd: black cores now give DD, peridoxin, rezadone, and regular nanobots
  • rscadd: added slime tiles, works like phazon tiles to slime people and slows everything else. you can get five from injecting iron into green cores
  • rscadd: added slime hearts, deals toxins to you if you hold it and if you're a slime person it heals toxins. You get one from injecting blood into green cores
  • rscadd: Adds a raincoat that you can get from the green core by injecting water, it can hold temp guns and slime lamps and gives cold protection.
  • rscdel: green cores no longer give medicine

@ghost
Copy link
Author

ghost commented Apr 13, 2017

pls no bully

@ghost
Copy link
Author

ghost commented Apr 13, 2017

Oh yeah, both cores still give their slime toxins with plasma

@Yelier
Copy link

Yelier commented Apr 13, 2017

Why exclude xenos from the gold core?

@ghost
Copy link
Author

ghost commented Apr 13, 2017

Oh shit I forgot to mention, when I exclude xenos from Golden cores I'm gonna a put a xeno egg reaction for dark purple cores so you can raise xenos in the max containment pens

@ghost ghost closed this Apr 13, 2017
@ghost
Copy link
Author

ghost commented Apr 13, 2017

Fuck

@ghost ghost reopened this Apr 13, 2017
@ghost
Copy link
Author

ghost commented Apr 13, 2017

Right now dark purples are only used for more plasma in case there are no miners and you somehow run out, even then you can get one mutation from purple and be completely fine with plasma since it's like 10 sheets? Might be 5

@Probe1
Copy link
Member

Probe1 commented Apr 13, 2017

.. okay why a raincoat? That isn't right. It shouts "I'm a placeholder". Either don't touch it or get to the tiles and slime heart content that you intend to do instead of leaving us holding the bag until you do.

@ghost
Copy link
Author

ghost commented Apr 13, 2017

@Probe1 monster musume memes, the raincoat will stay but I think I'll get a special sprite for it

@PJB3005 PJB3005 added the Content Adds something. Neat! label Apr 13, 2017
required_container = /obj/item/slime_extract/black
required_other = 1

/datum/chemical_reaction/slimecasp/on_reaction(var/datum/reagents/holder)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be slimerezadone?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honestly not sure, first time CODING instead of deleting a few lines

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh fuck nevermind i see it, will fix when can

@ComicIronic
Copy link
Contributor

What's the value of the reference?

@SonixApache
Copy link
Contributor

slime tiles sound interesting

@ghost
Copy link
Author

ghost commented Apr 14, 2017

Well I guess the coat can give some resistance to extinguishers so that it's not just cosmetic? It IS a raincoat after all

@ghost
Copy link
Author

ghost commented Apr 14, 2017

oh no! i messed up my local branch

@ghost
Copy link
Author

ghost commented Apr 14, 2017

alright so that should have fixed the rezadone line that wasn't actually copy pasted from the orange reaction

@ghost
Copy link
Author

ghost commented Apr 14, 2017

i got a not shit slime tile sprite
image
what it'll do is slow down anyone but slime people and will come from green cores at 5 tiles each reaction
just need to CODE IT which won't be too much time

@ghost
Copy link
Author

ghost commented Apr 15, 2017

and i managed to fuck my local branch again

@ghost
Copy link
Author

ghost commented Apr 15, 2017

i manged to unfuck my local branch again

@ghost
Copy link
Author

ghost commented Apr 16, 2017

tiles soon(within the next hour)

@ghost
Copy link
Author

ghost commented Apr 16, 2017

DONE
now to the slime heart and coat

@ghost
Copy link
Author

ghost commented Apr 16, 2017

oh yeah they delete when broken, slime completely loses it's form if you blow it up

@ghost
Copy link
Author

ghost commented Apr 16, 2017

broken as in from bombs, you can crowbar them up and shit

@ghost
Copy link
Author

ghost commented Apr 16, 2017

thanks shadowmech

@ghost ghost changed the title Rebalances black and green core reactions Rebalances black and green core reactions (WIP) Apr 16, 2017
@SonixApache
Copy link
Contributor

It's a hand-held object and not an organ?

@ghost
Copy link
Author

ghost commented Apr 18, 2017

Yeah, it might be used as an organ when it's time to balance slime people into a round start race ;-)
Right now it's a good item that deals with the problem of going too fast and walking into your own extinguisher sprays, I kept it a simple resprited green core like the yellow power cell

@@ -0,0 +1,28 @@
/obj/item/slime_heart
name = "Slime Heart"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove capitalization here, if it's capitalized BYOND treats it as a proper noun.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Th-thanks byond


obj/item/stack/tile/slime
name = "Tile of slime"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove capitalization.

else
C.adjustToxLoss(5)
cd = 1
spawn(1 SECONDS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Process gets called every 2 seconds so this shouldn't be needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which line exactly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the entire cd stuff.

icon_state = "tile-slime"
w_class = W_CLASS_MEDIUM
force = 1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove .0 here.

@ghost
Copy link
Author

ghost commented Apr 19, 2017

oh yeah and removed the .0
i guess you wanted me to remove the cd stuff because you thought it's not working how i wanted it to or something since we spoke a bit on discord? It works as intended, ticks every second

@@ -0,0 +1,28 @@
/obj/item/slime_heart
name = "slime Heart"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See now this just looks weird

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuck i forgot a letter

@ghost
Copy link
Author

ghost commented Apr 19, 2017

anything else?
probably gonna start that raincoat tomorrow
i'll slap it in with the winter coats so that it's not just a meme cosmetic

@ghost
Copy link
Author

ghost commented Apr 20, 2017

oh shit is adding a slimecoat this easy? i hope not

@ghost
Copy link
Author

ghost commented Apr 20, 2017

(lol

@ghost ghost changed the title Rebalances black and green core reactions (WIP) Rebalances black and green core reactions also adds three items (WIP) Apr 20, 2017
@ghost ghost changed the title Rebalances black and green core reactions also adds three items (WIP) Rebalances black and green core reactions also adds three items (nice) Apr 20, 2017
@ghost
Copy link
Author

ghost commented Apr 20, 2017

one more thing

@ghost
Copy link
Author

ghost commented Apr 20, 2017

noice

@ghost
Copy link
Author

ghost commented Apr 20, 2017

that SHOULD be it

@ghost ghost changed the title Rebalances black and green core reactions also adds three items (nice) Rebalances black and green core reactions also adds three items to green cores Apr 20, 2017
@ghost ghost changed the title Rebalances black and green core reactions also adds three items to green cores Rebalances black and green core reactions also adds three items to green cores (finished) Apr 21, 2017
@@ -5,24 +5,17 @@
icon_state = "Slime-Heart"
item_state = "Slime-Heart"
w_class = W_CLASS_TINY
var/cd = 0

/obj/item/slime_heart/New()
processing_objects.Add(src)
..()

/obj/item/slime_heart/process()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to OnMobLife(var/mob) and remove the New code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang c*ders

Copy link
Author

@ghost ghost Apr 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait isn't that the old code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nvm

@ghost ghost changed the title Rebalances black and green core reactions also adds three items to green cores (finished) Rebalances black and green core reactions also adds three items to green cores (fug) Apr 23, 2017
@ghost
Copy link
Author

ghost commented Apr 23, 2017

wait what

@PJB3005 PJB3005 merged commit ad30222 into vgstation-coders:Bleeding-Edge Apr 23, 2017
ihadtoregisterforthis pushed a commit to ihadtoregisterforthis/fork4 that referenced this pull request Jul 3, 2017
…een cores (fug) (vgstation-coders#14649)

* Rebalances black and green core reactions

* Rebalances black and green core reactions (reverted from commit 6776986)

* oh god what am i doing pls

* FINALLY finished slime tiles

* increases tiles you get to 5

* SLIME HEARTS NOW thanks intigracy for tht help

* removed capitalization

* shit

* fixed cd shit that wasn't needed apparently

* FUCK

* SPECIAL RAINCOAT FINISHED

* makes it possible to actually get the raincoat

* forgot to take off the original slime coat reaction

* did it the way c*ders wanted it
d3athrow pushed a commit that referenced this pull request Jul 4, 2017
…een cores (fug) (#14649)

* Rebalances black and green core reactions

* Rebalances black and green core reactions (reverted from commit 6776986)

* oh god what am i doing pls

* FINALLY finished slime tiles

* increases tiles you get to 5

* SLIME HEARTS NOW thanks intigracy for tht help

* removed capitalization

* shit

* fixed cd shit that wasn't needed apparently

* FUCK

* SPECIAL RAINCOAT FINISHED

* makes it possible to actually get the raincoat

* forgot to take off the original slime coat reaction

* did it the way c*ders wanted it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Adds something. Neat!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants