New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorblind preset for goonchat, gives non specific radio a different color. #14662
Conversation
I don't know why the tabs are fucked up. |
While we're at it could we make engineering a more distinct color, I'm not sure whether it's my color deficiency or not but I can't keep them separated. |
@PJB3005 engineering's color is way more dim and brownish, but I'll see what I can do in a few hours when I get back. |
I meant between common and engineering, at a glance I flat out cannot see the difference other than the [engineering] tag. |
Oh. Which is not to say they shouldn't be changed, because why make things harder for colorblind people? |
Should probably just give goonchat multiple color pallettes. |
Yeah, just have a Javascript fragment fuck with the CSS. |
Heavily updated the aim of the PR. |
The problem is that my type of color blindness is one type of color blindness, you may have made it better for me but you may have ruined it for somebody else and we wouldn't know. We need user selectable palettes. |
@PJB3005 This should work for everyone. I don't even know the type of color blindness you have. |
I think most games offer just 1 colorblindness mode because it'd be effort to implement and not worth dev time OR it's simply not something that matters as much. |
Battlefield series from 3 onwards offers like 3 modes. |
I'm working on a color preset switcher for goonchat, only need to test it now which involves the dreaded recompile. |
Color presets for goonchat.
So does this mean players will have the option to keep their chat colors as they are now? |
@Shadowmech88 yep. |
I think this is ready to go. |
Well, wait, it seems I still need to tweak some things. |
Done, also updated OP's screenshot. |
…color. (vgstation-coders#14662) * chat_colors * colorblind * Goonchat color preset system. * Revert CSS file changes. * colorblind_v2 * fix
…color. (#14662) * chat_colors * colorblind * Goonchat color preset system. * Revert CSS file changes. * colorblind_v2 * fix
It works on my machine. But I have no idea if all of the stuff I added was actually needed. The thing is that I had to make the common channel a separate channel from the radio channels, which was not the case before.
UPDATE: this now changes the chat palette to be colorblind friendly.
With a new preset.
Explaining
The reason and purpose is to properly identify other channels that are not thecommon
one more easily.Orange is basically the only color left to use.
Tweaks so that colors are now colorblind friendly. Also, separates the radio colors from the Common radio color, explained above.
In-game changelog
🆑