Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorblind preset for goonchat, gives non specific radio a different color. #14662

Merged
merged 7 commits into from Apr 16, 2017

Conversation

eplgr
Copy link
Contributor

@eplgr eplgr commented Apr 15, 2017

It works on my machine. But I have no idea if all of the stuff I added was actually needed. The thing is that I had to make the common channel a separate channel from the radio channels, which was not the case before.

UPDATE: this now changes the chat palette to be colorblind friendly.

With a new preset.

Explaining

The reason and purpose is to properly identify other channels that are not the common one more easily.
Orange is basically the only color left to use.

Tweaks so that colors are now colorblind friendly. Also, separates the radio colors from the Common radio color, explained above.

In-game changelog

🆑

  • rscadd: Added colorblind preset for goonchat (you can find it under the chat's configuration button along with the other options)
  • rscadd: Common and radio channels now have different colors: common kept the green, radio is now orange.

@eplgr
Copy link
Contributor Author

eplgr commented Apr 15, 2017

I don't know why the tabs are fucked up.

@Probe1 Probe1 self-requested a review April 15, 2017 00:32
@Probe1 Probe1 added the Content Adds something. Neat! label Apr 15, 2017
@PJB3005
Copy link
Contributor

PJB3005 commented Apr 15, 2017

While we're at it could we make engineering a more distinct color, I'm not sure whether it's my color deficiency or not but I can't keep them separated.

@eplgr
Copy link
Contributor Author

eplgr commented Apr 15, 2017

@PJB3005 engineering's color is way more dim and brownish, but I'll see what I can do in a few hours when I get back.

@PJB3005
Copy link
Contributor

PJB3005 commented Apr 15, 2017

I meant between common and engineering, at a glance I flat out cannot see the difference other than the [engineering] tag.

@Exxion
Copy link
Member

Exxion commented Apr 15, 2017

Oh.
Yeah they're completely different if you're not colorblind

Which is not to say they shouldn't be changed, because why make things harder for colorblind people?

@PJB3005
Copy link
Contributor

PJB3005 commented Apr 15, 2017

Should probably just give goonchat multiple color pallettes.

@N3X15
Copy link
Contributor

N3X15 commented Apr 15, 2017

Yeah, just have a Javascript fragment fuck with the CSS.

@PJB3005 PJB3005 added UI Edits UI in some way. and removed Content Adds something. Neat! labels Apr 15, 2017
@eplgr eplgr changed the title Changes color of the radio channel Chat colors are now colorblind friendly, changes color of the radio channel Apr 15, 2017
@eplgr
Copy link
Contributor Author

eplgr commented Apr 15, 2017

Heavily updated the aim of the PR.
Also, suggestions are welcome but before posting I'd suggest you give http://safecolours.rigdenage.com/colourchoice.html a read.

@PJB3005
Copy link
Contributor

PJB3005 commented Apr 15, 2017

The problem is that my type of color blindness is one type of color blindness, you may have made it better for me but you may have ruined it for somebody else and we wouldn't know.

We need user selectable palettes.

@eplgr
Copy link
Contributor Author

eplgr commented Apr 15, 2017

@PJB3005 This should work for everyone. I don't even know the type of color blindness you have.
Just think of any other game: they offer just 1 colorblind mode for a reason.

@PJB3005
Copy link
Contributor

PJB3005 commented Apr 15, 2017

I think most games offer just 1 colorblindness mode because it'd be effort to implement and not worth dev time OR it's simply not something that matters as much.

@SonixApache
Copy link
Contributor

Battlefield series from 3 onwards offers like 3 modes.

@PJB3005
Copy link
Contributor

PJB3005 commented Apr 15, 2017

I'm working on a color preset switcher for goonchat, only need to test it now which involves the dreaded recompile.

@PJB3005
Copy link
Contributor

PJB3005 commented Apr 15, 2017

eplgr#2

Color presets for goonchat.
@PJB3005 PJB3005 added the Goonchat Touches chat code. label Apr 15, 2017
@Shadowmech88
Copy link
Contributor

So does this mean players will have the option to keep their chat colors as they are now?

@PJB3005 PJB3005 changed the title Chat colors are now colorblind friendly, changes color of the radio channel Colorblind preset for goonchat, gives non specific radio a different color. Apr 15, 2017
@PJB3005
Copy link
Contributor

PJB3005 commented Apr 15, 2017

@Shadowmech88 yep.

@eplgr
Copy link
Contributor Author

eplgr commented Apr 16, 2017

I think this is ready to go.

@eplgr
Copy link
Contributor Author

eplgr commented Apr 16, 2017

Well, wait, it seems I still need to tweak some things.

@eplgr
Copy link
Contributor Author

eplgr commented Apr 16, 2017

Done, also updated OP's screenshot.

@Intigracy Intigracy merged commit 9910f10 into vgstation-coders:Bleeding-Edge Apr 16, 2017
ihadtoregisterforthis pushed a commit to ihadtoregisterforthis/fork4 that referenced this pull request Jul 3, 2017
…color. (vgstation-coders#14662)

* chat_colors

* colorblind

* Goonchat color preset system.

* Revert CSS file changes.

* colorblind_v2

* fix
d3athrow pushed a commit that referenced this pull request Jul 4, 2017
…color. (#14662)

* chat_colors

* colorblind

* Goonchat color preset system.

* Revert CSS file changes.

* colorblind_v2

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Goonchat Touches chat code. UI Edits UI in some way.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants