Hyperzine prevents Diona regeneration. Hyperzine no longer speeds up Diona as much as it used to. #14721

Anton-Kr · 2017-04-23T06:41:00Z

Tired of green fuckers running to your chem station every round begging for their pills to make them even more OP? Worry no longer.

Changelog

🆑

tweak: Hyperizine prevents Diona health regeneration
tweak: Hyperizine speedups for Diona are nowhere near as powerful as they were before.

update

ultraplen · 2017-04-23T07:54:58Z

A fair nerf. Possibly a bit harsh.

BobdaBiscuit · 2017-04-23T08:09:46Z

If only you knew what kind of hell you are inviting in by doing this.

Kurfursten · 2017-04-23T09:17:25Z

With the current numbers, this will crit a Diona in 13 seconds, consuming 0.39u Hyperzine

The low lethal dosage should be taken into account when considering splash/smoke mechanics

PJB3005 · 2017-04-23T09:31:40Z

Yeah the damage is WAY over the top.

Make it more manageable but still not something you want to consistently use.

PJB3005 · 2017-04-23T09:31:53Z

code/modules/reagents/Chemistry-Reagents.dm

+
+	if(ishuman(M))
+		var/mob/living/carbon/human/H = M
+		if(H.species.name == "Diona")


Use isdiona(H)

Fruktlimpa · 2017-04-23T14:27:58Z

Dionae is a pretty shit race lets not lie. The massive slowdown would make them extremely annoying to play which is why everyone chugs hyperzine in the first place.
Instead of making hyperzine a death sentence or forcing them to chug other pills at the same rate. Isn't it possible to make them slightly slower than a human by consuming hyperzine?
I realize it isn't ideal because it would still force them to chug hyperzine but at least then they wouldn't be speedy trees of no brute damage.

Anton-Kr · 2017-04-23T15:05:18Z

Im going to make the damage dealt a lot more reasonable (and potentially counteracted with chems) and also make the speed up to not be as great as it is for other species.

Anton-Kr · 2017-04-23T15:08:08Z

Will also try to make regeneration not work for diona while on hyperzine in which case Ill probably reduce damage dealt even more so

BobdaBiscuit · 2017-04-23T15:21:48Z

IMO, if you make hyperzine not make dionas sanic, and then disable their regen while under it's effects the damage is unneeded.

Ephx1 · 2017-04-23T15:50:05Z

It begins!

Blithering · 2017-04-23T16:59:21Z

Disabling the regen when hyperzine is present as @BobdaBiscuit suggested seems like a fair tradeoff to me, not sure how feasible that is code wise though

BobdaBiscuit · 2017-04-23T17:00:29Z

It's perfectly possible, I had a look through the code for em and it's just a isdiona() + has hyperzine test and we're gucci

Kurfursten · 2017-04-23T17:47:44Z

I think disabling the regeneration is an interesting idea, because combat is when you would most want regeneration AND movement speed, and it's not trivial for most jobs to remove the hyperzine when combat is over unless you're carrying a pAI to smoke it out.

Overall, I appreciate its simplicity and balance as an idea.

Anton-Kr · 2017-04-23T17:54:33Z

Alright, so no damage dealt to diona, but no regen, and speed buff is nerfed.

Exxion · 2017-04-23T18:28:43Z

If it's less effective AND prevents regeneration, is the damage really necessary?

Anton-Kr · 2017-04-23T18:35:18Z

@PJB3005 Let me know if there are any other issues.

Anton-Kr · 2017-04-23T18:35:40Z

@Exxion It isn't. I forgot to remove it in last commit.

gbasood · 2017-04-24T00:30:37Z

Dionae is a pretty shit race lets not lie.

Yeah man regenerating through anything but burn damage
So shit

Exxion · 2017-04-24T01:34:04Z

And taking enough burn damage to be critted in two (2) standard laser shots

Exxion · 2017-04-24T01:55:19Z

Consider these options:

Git Gud

gbasood · 2017-04-24T02:08:06Z

I'd rather make a balance change that's overkill and then find a halfway point afterwards than fiddle around with multiple PRs that are "too harsh man" according to a small subset of players

ghost · 2017-04-24T05:05:44Z

just make hyperzine heat up bodies enough to deal burn if you overdose

Fruktlimpa · 2017-04-24T07:07:23Z

@gbasood

Yeah man regenerating through anything but burn damage
So shit

I meant more in a sense that they are a stupid meme race that literally cannot function without hyperzine. Anyone who would willingly play Dionae without so much as a drop of hyperzine is insane.

ghost · 2017-04-24T08:58:19Z

I think this PR is bad because it changes the two main diona things, which is being slow and having high regen. Diona already suck, even with non nerfed hyperzine. Here is my ideas to fix diona, and make them more like tree people they should be.

slightly faster base movement speed (still slower than human)
unaffected by zas
chemicals don't work on them

No zas, can't be chloral or sleepypen meme'd but they're stuck being sorta slow forever because they can't eat hyperzine.

Shadowmech88 · 2017-04-24T09:03:05Z

I keep seeing people claim that dionae are OP.

Now, I haven't played in a while, so I'm honestly asking: are there a significant number of players rolling dionae? Something like 30%-40% at least?
Because that's what I would expect to happen if we had a race that was truly overpowered, that a significant number of people would be playing it for the advantage it offered.

BobdaBiscuit · 2017-04-24T11:00:15Z

Actually we had a week were the majority of sec teams were all diona, is was a pretty funny meme.

SonixApache · 2017-04-24T13:23:42Z

if you're going to take away their regen you might as well make them as fast as humans
level the playing field rather than home advantage

and while we're at it, antitox ODing when?

Anton-Kr · 2017-04-24T13:34:48Z

Regen is still there but only when they have no hyperzine in system

SonixApache · 2017-04-24T13:37:40Z

Yes, that's the point. If they don't have their bullshit regeneration anymore, why make them slower still than humans on drugs?

FudgePucker · 2017-04-24T21:51:29Z

Number one murder bone weapon is egun.
Zap and laser to death.
Number one lethal option security has is egun.
Zap and laser to death.
Everybody has a toolbelt with a welder.
Stuns are king burn damage is second.

Hell they can't survive polyacid smoke grenades. How are they super OP again?

I like Solarious' idea. They are so slow it takes half a round to cross the station, you take hyperzine or roleplay a tree. A minor speed nerf instead of a super major "oh god how can it be possible to move this slow" one. Nerf regen so you can kill one in full light with a esword and then we have balance.

Blithering · 2017-04-24T23:26:55Z

Combat isn't the only factor when considering a race's strengths. Remember they don't need to breathe or eat, are unaffected by pressure, heal from radiation, can shrug off ZAS and ignore overdose limits on meds. Surviving as a diona is a lot simpler because you can pretty much ignore everything that isn't fire.

Exxion · 2017-04-24T23:33:40Z

At the cost of walking at roughly the same speed as a slime mold.
Which is why hyperzine is too good for them, which is why this PR exists

Also, all of you fucks saying that dionae are unplayably slow need to either get more patient or stop playing dionae

Intigracy · 2017-04-25T01:46:34Z

Clearly we should just make dionae unable to move.

Shadowmech88 · 2017-04-25T01:48:36Z

They are trees, after all. Trees don't move.

Intigracy · 2017-04-25T01:49:38Z

wait sorry wrong meme

the obvious solution is to remove skeletons

Did what he was told

DamianX · 2017-04-25T17:10:54Z

Fix the changelog already

ComicIronic

Needs fixing.

ComicIronic · 2017-04-27T00:22:16Z

code/modules/mob/living/carbon/human/human_movement.dm

@@ -76,6 +76,8 @@
 	if(reagents.has_reagent(HYPERZINE))
 		if(dna.mutantrace == "slime")
 			tally *= 2
+		if(isdiona(src))


Use else if.

ComicIronic · 2017-04-27T00:22:43Z

code/modules/mob/living/carbon/human/life/handle_chemicals_in_body.dm

@@ -42,7 +42,7 @@
 		if(species.flags & IS_PLANT)
 			if(nutrition > 500)
 				nutrition = 500
-			if(light_amount >= 3) //If there's enough light, heal
+			if(light_amount >= 3 & !reagents.has_reagent(HYPERZINE)) //If there's enough light, and you do not have hyperzine in body, heal


Use &&, & is a bitwise operation.

Anton-Kr · 2017-04-27T17:17:33Z

@ComicIronic done

BobdaBiscuit · 2017-04-27T17:25:12Z

How fast is it ingame compared to the human base speed? Cause the tally boost seems hella lower.

Anton-Kr · 2017-04-27T17:32:18Z

@BobdaBiscuit Human slowdown by default is 0. Diona is 7 without hyperzine, and 3 with, so somewhat slower then humans still.

BobdaBiscuit · 2017-04-27T17:35:18Z

Eh if it's still too slow I suppose another pr can be made to tweak it.

Anton-Kr · 2017-05-14T21:55:18Z

MERGE WHEN

BobdaBiscuit · 2017-05-14T22:03:22Z

>"fair" diona nerf that most people agree with
>still not merged nearly a month later

REALLY MAKES YOU THINK

Intigracy · 2017-05-14T22:26:19Z

If this needs adjusting we can do so.

…Diona as much as it used to. (vgstation-coders#14721) * 'Done' * fixes * Forgot to remove damage * Fix 2

…Diona as much as it used to. (#14721) * 'Done' * fixes * Forgot to remove damage * Fix 2

Anton-Kr added 2 commits April 22, 2017 16:11

Merge pull request #1 from vgstation-coders/Bleeding-Edge

3b9bd7e

update

'Done'

677b201

PJB3005 added the Balance Potentially going to upset people as it changes balance of the game. label Apr 23, 2017

PJB3005 previously requested changes Apr 23, 2017

View reviewed changes

fixes

b33de28

Forgot to remove damage

5b55eb0

Anton-Kr changed the title ~~Makes hyperzine poisonous for diona.~~ Hyperzine prevents Diona regeneration. Hyperzine no longer speeds up Diona as much as it used to. Apr 23, 2017

PJB3005 approved these changes Apr 26, 2017

View reviewed changes

ComicIronic suggested changes Apr 27, 2017

View reviewed changes

Fix 2

f0d18c1

ComicIronic approved these changes Apr 27, 2017

View reviewed changes

Intigracy merged commit 1b1ca39 into vgstation-coders:Bleeding-Edge May 14, 2017

d3athrow pushed a commit that referenced this pull request Jul 4, 2017

Hyperzine prevents Diona regeneration. Hyperzine no longer speeds up …

373c2d7

…Diona as much as it used to. (#14721) * 'Done' * fixes * Forgot to remove damage * Fix 2

This was referenced Mar 12, 2018

Reverts unintended buff to diona photosynthesis #17820

Merged

Based on a recent finding, reverts diona hyperzine allergy to only toxloss #17821

Closed

[Discussion] Do you want a Dionaea rebalancing following #17820? #17846

Closed

Hyperzine prevents Diona regeneration. Hyperzine no longer speeds up Diona as much as it used to. #14721

Hyperzine prevents Diona regeneration. Hyperzine no longer speeds up Diona as much as it used to. #14721

Conversation

Anton-Kr commented Apr 23, 2017 • edited by Intigracy

Changelog

ultraplen commented Apr 23, 2017

BobdaBiscuit commented Apr 23, 2017

Kurfursten commented Apr 23, 2017

PJB3005 commented Apr 23, 2017

PJB3005 Apr 23, 2017

Choose a reason for hiding this comment

Fruktlimpa commented Apr 23, 2017

Anton-Kr commented Apr 23, 2017

Anton-Kr commented Apr 23, 2017

BobdaBiscuit commented Apr 23, 2017

Ephx1 commented Apr 23, 2017

Blithering commented Apr 23, 2017

BobdaBiscuit commented Apr 23, 2017

Kurfursten commented Apr 23, 2017

Anton-Kr commented Apr 23, 2017

Exxion commented Apr 23, 2017

Anton-Kr commented Apr 23, 2017

Anton-Kr commented Apr 23, 2017

gbasood commented Apr 24, 2017

Exxion commented Apr 24, 2017

Exxion commented Apr 24, 2017

gbasood commented Apr 24, 2017 • edited

ghost commented Apr 24, 2017

Fruktlimpa commented Apr 24, 2017

ghost commented Apr 24, 2017

Shadowmech88 commented Apr 24, 2017

BobdaBiscuit commented Apr 24, 2017

SonixApache commented Apr 24, 2017 • edited

Anton-Kr commented Apr 24, 2017

SonixApache commented Apr 24, 2017

FudgePucker commented Apr 24, 2017

Blithering commented Apr 24, 2017

Exxion commented Apr 24, 2017

Intigracy commented Apr 25, 2017

Shadowmech88 commented Apr 25, 2017

Intigracy commented Apr 25, 2017

DamianX commented Apr 25, 2017

ComicIronic left a comment

Choose a reason for hiding this comment

ComicIronic Apr 27, 2017

Choose a reason for hiding this comment

ComicIronic Apr 27, 2017

Choose a reason for hiding this comment

Anton-Kr commented Apr 27, 2017

BobdaBiscuit commented Apr 27, 2017

Anton-Kr commented Apr 27, 2017

BobdaBiscuit commented Apr 27, 2017

Anton-Kr commented May 14, 2017

BobdaBiscuit commented May 14, 2017 • edited

Intigracy commented May 14, 2017

Anton-Kr commented Apr 23, 2017 •

edited by Intigracy

gbasood commented Apr 24, 2017 •

edited

SonixApache commented Apr 24, 2017 •

edited

BobdaBiscuit commented May 14, 2017 •

edited