adds power creep #14760
adds power creep #14760
Conversation
| spawn(rand(1,3) SECONDS) | ||
| var/power_to_use = min(charge, rand(800,1200)) | ||
| playsound(loc, 'sound/effects/eleczap.ogg', 80, 1) | ||
| use(power_to_use) |
There was a problem hiding this comment.
The sound effect and the rest of the code should be indented under an if for this - if the cell can't give you the power you want, this returns a 0.
| ) | ||
| result = /obj/item/weapon/cell/crepe | ||
| time = 300 |
There was a problem hiding this comment.
since no other kitchen recipe uses this, it might confuse people
|
Good shit 👌 |
| @@ -112,6 +112,27 @@ | |||
| w_type = RECYK_BIOLOGICAL | |||
| minor_fault = 1 | |||
|
|
|||
| /obj/item/weapon/cell/crepe | |||
| name = "power crepe" | |||
There was a problem hiding this comment.
Don't have atom on this computer, will have to wait till monday for accents
There was a problem hiding this comment.
What if you add it via editing the file on Github?
| @@ -112,6 +112,27 @@ | |||
| w_type = RECYK_BIOLOGICAL | |||
| minor_fault = 1 | |||
|
|
|||
| /obj/item/weapon/cell/crepe | |||
| name = "power crepe" | |||
| desc = "Warning: May contain dairy products, 12,000kw of searing death, gluten." | |||
There was a problem hiding this comment.
That's still the wrong unit, so who cares
There was a problem hiding this comment.
wouldn't it be just (J) Joules in this case? or 12kJ ?
| if(use(power_to_use)) | ||
| user.adjustFireLoss(power_to_use/100) //So 8 to 12 damage | ||
| user.visible_message("<span class = 'notice'>\The [user] is electrocuted by \the [src]</span>", "<span class = 'warning'>You are [pick("frazzled","electrocuted","zapped")] by \the [src]!</span>") | ||
| user.set_light(2,2,"#ffff00") |
There was a problem hiding this comment.
Doesn't this fuck with things like getting set on fire?
There was a problem hiding this comment.
If you're on fire, why are you eating something that deals burn damage?
There was a problem hiding this comment.
Well, how would you recommend doing it?
Most things that update lighting update it every so few ticks (The light virus effect, radglow, and I would assume fire), but there's no real way to revert back to that with this.
Two ways I can think of doing it. Store the light settings in temporary variables to be restored after the cooldown, or check if the person is alight already and if so don't light them up.
There was a problem hiding this comment.
To handle this properly you need wrappers, managers for lighting colors and whatever.
so... I'd just recommend it not doing anything if they're already lit. Not perfect but least effort.
What you'd need is a list of light effects on mobs, then produce a final color, range and power based on all of those.
|
??? |
|
are we ready to approve because this is an amazing pr |
|
Make sure you update the wiki. |
This reverts commit 32d889c.
* adds power creep * proper check for cell usage * trying the in-browser editor
* adds power creep * proper check for cell usage * trying the in-browser editor
ghost
deleted the
No description provided.