Add balance PR related rules to the CONTRIBUTING.md #15593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbasood
added
the
System
N3X15
reviewed
Jul 31, 2017
CONTRIBUTING.md
Outdated
| @@ -10,6 +10,12 @@ CONTRIBUTING TO VGSTATION | |||
| * **Large changes require discussion.** If you're doing a large, game-changing modification, or a new layout for something, discussion with the community is required as of 26/6/2014. Map and sprite changes require pictures of before and after. **MAINTAINERS ARE NOT IMMUNE TO THIS. GET YOUR ASS IN IRC.** | |||
Intigracy
reviewed
Jul 31, 2017
CONTRIBUTING.md
Outdated
| # Balance changes | ||
| * **Balance changes must require that feedback be sought out from the players.** For example, server polls. This does not mean you pop into #code-talk in Discord and ask about it once. Good examples include: | ||
| * Server polls | ||
| * bringing attention to your PR via in-game OOC, ideally over several time slots. |
Intigracy
reviewed
Jul 31, 2017
| * Server polls. Duration of the poll should be longer than 24 hours at minimum. Use best judgment. | ||
| * Bringing attention to your PR via in-game OOC, ideally over several time slots. | ||
| * **Balance change PRs need changelogs. Always.** | ||
| * **If you are a collaborator,** allow sufficient time for feedback to be gathered, and make sure that it *has* been gathered. |
There was a problem hiding this comment.
How about something about not begging for merges before the other requirements are met?
There was a problem hiding this comment.
I feel like people doing that would have no read this in the first place.
N3X15
reviewed
Aug 1, 2017
| @@ -7,9 +7,16 @@ CONTRIBUTING TO VGSTATION | |||
| * This means, primarily, that you shouldn't fix bugs **and** add content in the same PR. When we mean 'bundling', we mean making one PR for multiple, unrelated changes. | |||
| * **Test your changes.** PRs that do not compile will not be accepted. | |||
| * Testing your changes locally is incredibly important. If you break the serb we will be very upset with you. | |||
| * **Large changes require discussion.** If you're doing a large, game-changing modification, or a new layout for something, discussion with the community is required as of 26/6/2014. Map and sprite changes require pictures of before and after. **MAINTAINERS ARE NOT IMMUNE TO THIS. GET YOUR ASS IN IRC.** | |||
| * **Large changes require discussion.** If you're doing a large, game-changing modification, or a new layout for something, discussion with the community is required as of 26/6/2014. Map and sprite changes require pictures of before and after. **MAINTAINERS ARE NOT IMMUNE TO THIS. GET YOUR ASS IN THE CODE DISCORD.** (link in README.md) | |||
There was a problem hiding this comment.
Needs minimum discussion duration
There was a problem hiding this comment.
I'm not sure how you would quantify that. Suggestions?
There was a problem hiding this comment.
I think the minimum discussion duration is already handled by the 24h before merge portion.
|
I have no further objections. |
N3X15
added
Balance
|
Bumped importance, added to balance tag since it's currently blocking Balance PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, these need some harder guidelines than general PRs.
Let me know if you think this is clear enough or needs to be changed up.