Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RETURN OF THE CLUWNE BAN #15645

Closed

Conversation

N3X15
Copy link
Contributor

@N3X15 N3X15 commented Aug 6, 2017

DONUT MERGE

This is currently under testing, and still needs VGWS integration.

Executive Summary

Back on my server, there used to be a way to ban people so that they became cluwnes on roundstart.

This brings that back using the /event API, but should be more reliable.

Important Distinctions

This ban operates a little differently than normal bans, as it uses the same ban type but uses the duration to determine permanence.

  • duration == -1: Permanent Ban
  • duration >= 0: Temporary Ban

TODO

  • VGWS Integration
  • Catbeast bans?
  • Appeal Bans
  • Ban/admin edition of cluwne that cannot die and cannot attack at all
  • Testing

@N3X15 N3X15 added Logging / Administration This touches things involving admins or logging. ✋ Do Not Merge ✋ Don't you do it. labels Aug 6, 2017
@PJBot PJBot added the Secret repo conflict. Conflicts with the secret repo in some way, it's on whoever merges it to merge changes to the SR too label Aug 6, 2017
@N3X15
Copy link
Contributor Author

N3X15 commented Aug 6, 2017

Already done, all cluwnes are assigned assistant prior to job assignment.

https://github.com/vgstation-coders/vgstation13/pull/15645/files#diff-ad5730becbdced110e633cef24155bb5R23

@N3X15
Copy link
Contributor Author

N3X15 commented Aug 6, 2017

I should also mention that a Cluwneban automatically jobbans you from all positions except assistant, so AI, head, and antag roles will not try to force them into something.

https://github.com/vgstation-coders/vgstation13/pull/15645/files#diff-c9da95830324d9b24daebaf98f064f2bR21

@Shadowmech88
Copy link
Contributor

Can cluwnes talk? Can they use items?
Is there any reason for someone who is cluwnebanned to actually play instead of just observing or waiting it out?

@Exxion
Copy link
Member

Exxion commented Aug 7, 2017

Cluwnes can never use items by virtue of having no hands
Unless these specific cluwnes are different, they can talk, but with nearly every word replaced with a HONK, rendering it almost entirely incomprehensible

@Shadowmech88
Copy link
Contributor

Shadowmech88 commented Aug 7, 2017

Why would anyone who is cluwnebanned choose to play, then?

@Exxion
Copy link
Member

Exxion commented Aug 7, 2017

Because they are not rational people

@Aurx
Copy link
Contributor

Aurx commented Aug 7, 2017

We have code for detecting AFK admins. We can tell when somebody logs in or out.
Couldn't we make it so that cluwnebans last for a specified number of rounds, and a round doesn't count if you don't participate for a significant fraction of it?

@Icychocobo
Copy link

Well, what would even count as "participation" in this case? Shuffling around for ten minutes while spouting various volumes and pitches of HONK?

I mean, I HONK what the change HONK getting at, but HONK seems HONK little HONK HONK HONK HONK HONK HONK. HONK HONK HONK lawn gnomes HONK HONK HONK station HONK HONK HONK nuke.

@Exxion
Copy link
Member

Exxion commented Aug 7, 2017

@Aurx Yeah, we COULD do that, but really I think this kind of ban is more for the memes
Like if we unbanned but cluwnebanned 2hotdogs or Sarca, they'd definitely still play
It would be like unbanning Kingston but forcing him to be a tajaran with infinite braindamage, but less personalized

@N3X15
Copy link
Contributor Author

N3X15 commented Aug 7, 2017

We could, but I'm not fucking with the database schema to enable that.

@gbasood gbasood added the Conflicts Conflicts with something. label Aug 8, 2017
@PJB3005 PJB3005 added the Derelict For content PRs that were closed, but contain functional features/code to salvage. label Nov 3, 2017
@PJB3005 PJB3005 closed this Nov 3, 2017
@Intigracy Intigracy added ✋ Do Not Merge ✋ Don't you do it. and removed ✋ Do Not Merge ✋ Don't you do it. Secret repo conflict. Conflicts with the secret repo in some way, it's on whoever merges it to merge changes to the SR too labels Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conflicts Conflicts with something. Derelict For content PRs that were closed, but contain functional features/code to salvage. ✋ Do Not Merge ✋ Don't you do it. Logging / Administration This touches things involving admins or logging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants