Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leatherworking improvements #16887

Merged
merged 4 commits into from Jan 17, 2018
Merged

Leatherworking improvements #16887

merged 4 commits into from Jan 17, 2018

Conversation

MadmanMartian
Copy link
Contributor

@MadmanMartian MadmanMartian commented Dec 27, 2017

The leather you use now matters slightly, as it names the final object.

Leather recipes added

  • Cowboy hat
  • Leather botanist gloves
  • Leather shoes
  • Leather Satchel
  • Leather Wallet
  • Leather armor (Hat and suit, apply different hides to give it different properties)

Requests

  • Human skin hide sheet sprite - Human skin hide is in the code, but it lacks a sprite and an acquisition form. If I had a sprite, I'd add it to human butchering. Courtesy of @Blithering
  • More leatherwork recipe ideas.

🆑

  • rscadd: More leather recipes added.
  • rscadd: The crafted leather items now inherit the name of the source of the leather. Corgi leather cowboy hats, Cat leather shoes, et cetera.

@MadmanMartian
Copy link
Contributor Author

leather satchel can be done, yes.

Coat would require a sprite. It's another thing in the code without an icon.

@MadmanMartian MadmanMartian added Needs Spritework Code done, need sprites. Content Adds something. Neat! labels Dec 27, 2017
@Jubisloviu
Copy link
Contributor

Leather Jackets would be nice
Leather Armor maybe?, imagine styling a xenomorph leather armor on hallways!
Gimp Suits
Leather Belts, not tool-belts, just normal belts for fashion purposes
Fingerless Leather gloves.
that Van Darkholme mask

@strawberrytan
Copy link

Vox skin tajaran skin and rare premium unathi skin when

@small-boss
Copy link
Contributor

furcoats when

@Blithering
Copy link
Contributor

Xenomorph hide gear was part of snowmap, there might be something salvageable from that

@IconDiffBot
Copy link

Icons with diff:

icons/mob/head.dmi
Key Old New Status
helmet_leather_deer3 helmet_leather_deer3 Created
helmet_leather2 helmet_leather2 Created
helmet_leather_xeno3 helmet_leather_xeno3 Created
helmet_leather3 helmet_leather3 Created
helmet_leather_corgi2 helmet_leather_corgi2 Created
helmet_leather_deerNH1 helmet_leather_deerNH1 Created
helmet_leather_deerNH2 helmet_leather_deerNH2 Created
helmet_leather_xeno2 helmet_leather_xeno2 Created
helmet_leather_deer2 helmet_leather_deer2 Created
helmet_leather_xeno1 helmet_leather_xeno1 Created
helmet_leather_deerNH3 helmet_leather_deerNH3 Created
helmet_leather_corgi3 helmet_leather_corgi3 Created
helmet_leather1 helmet_leather1 Created
helmet_leather_deer1 helmet_leather_deer1 Created
helmet_leather_corgi1 helmet_leather_corgi1 Created
helmet_leather_corgi helmet_leather_corgi Created
helmet_leather_deerNH helmet_leather_deerNH Created
helmet_leather_deer helmet_leather_deer Created
helmet_leather_xeno helmet_leather_xeno Created
helmet_leather helmet_leather Created
icons/mob/suit.dmi
Key Old New Status
suit_leather_corgi suit_leather_corgi Created
suit_leather_deer1 suit_leather_deer1 Created
suit_leather_deer suit_leather_deer Created
suit_leather_deer2 suit_leather_deer2 Created
suit_leather_deer3 suit_leather_deer3 Created
suit_leather_xeno suit_leather_xeno Created
suit_leather_xeno3 suit_leather_xeno3 Created
suit_leather_corgi3 suit_leather_corgi3 Created
suit_leather2 suit_leather2 Created
suit_leather3 suit_leather3 Created
suit_leather suit_leather Created
suit_leather1 suit_leather1 Created
suit_leather_xeno2 suit_leather_xeno2 Created
suit_leather_xeno1 suit_leather_xeno1 Created
suit_leather_corgi2 suit_leather_corgi2 Created
suit_leather_corgi1 suit_leather_corgi1 Created
icons/obj/clothing/hats.dmi
Key Old New Status
helmet_leather_deerNH helmet_leather_deerNH Created
helmet_leather_xeno helmet_leather_xeno Created
helmet_leather helmet_leather Created
helmet_leather_corgi helmet_leather_corgi Created
helmet_leather_deer helmet_leather_deer Created
icons/obj/clothing/suits.dmi
Key Old New Status
suit_leather_corgi suit_leather_corgi Created
suit_leather_deer suit_leather_deer Created
suit_leather suit_leather Created
suit_leather_xeno suit_leather_xeno Created

… has the word 'leather' in it before changing its name.
@IconDiffBot
Copy link

Icons with diff:

icons/obj/butchering_products.dmi
Key Old New Status
sheet-human sheet-human Created

@MadmanMartian MadmanMartian removed the Needs Spritework Code done, need sprites. label Jan 12, 2018
@N3X15
Copy link
Contributor

N3X15 commented Jan 12, 2018

SINCE WHEN DID WE HAVE AN ICON DIFF BOT

WHAT THE HELL

@DamianX
Copy link
Contributor

DamianX commented Jan 12, 2018

SINCE THE DAY I ASKED TG TO SHARE, NOW CALM DOWN

@DamianX
Copy link
Contributor

DamianX commented Jan 17, 2018

changelog so that we can be good to go?

@DamianX DamianX merged commit 4dae763 into vgstation-coders:Bleeding-Edge Jan 17, 2018
@MadmanMartian MadmanMartian deleted the leatherworking_fun branch January 17, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Adds something. Neat!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants