Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scratch-Off Lotto Tickets #31992

Merged
merged 23 commits into from
Feb 18, 2022
Merged

Conversation

west3436
Copy link
Collaborator

@west3436 west3436 commented Feb 4, 2022

Adds 4 tiers of lotto tickets for purchase at table-mounted vendors. Scratch the tickets off using something sharp or a coin then examine them to see if you've won anything. Tickets can be cashed in by inserting the ticket into the vendor you purchased them at. Prices and max prizes are as followings:
Tier 1 (Gold Rush): 5 credits to buy, 100,000 credit max prize.
Tier 2 (Diamond Hands): 20 credits to buy, 400,000 credit max prize.
Tier 3 (Phazon Fortune): 50 credits to buy, 1,000,000 credit max prize.
Tier 4 (Supermatter Surprise) (Contraband): 100 credits to buy, 100,000 credit max prize. Prize guaranteed, but the ink used on this one is not compliant to Space-OSHA regulations.

new
Credit to @kane-f for the vending machine sprite and animation and @IThe-TI for the lotto ticket sprites.

Odds:
image

Vendors will be mapped in as a separate PR.

-->
🆑

  • rscadd: Lotto tickets may now be purchased at wall-mounted vendors and cashed out at the Cargo Bay.

@adacovsk
Copy link
Contributor

adacovsk commented Feb 4, 2022

this will make slot machines obsolete

@Eneocho
Copy link
Collaborator

Eneocho commented Feb 4, 2022

this will make slot machines obsolete

Not quite, the odds for the massive prizes are way smaller than the slot machines'. You have better odds to win jackpot in the slots than any decently large prize in the lotto.
It basically is just another moneysink.

@Kurfursten
Copy link
Collaborator

Kurfursten commented Feb 4, 2022

I have looked at these numbers and they seem well thought out.

I will want to see the list for Supermatter of course. I'm also not sure how you could get it into the supply console to redeem it based on how it works.

@west3436
Copy link
Collaborator Author

west3436 commented Feb 4, 2022

I will want to see the list for Supermatter of course. I'm also not sure how you could get it into the supply console to redeem it based on how it works.

It's a guaranteed 100,000 credit win but it can't be cashed ever since you can't pickup a Supermatter Splinter. It's a prank item, really. If someone finds an exploit and figures out a way to pick it up, then 100,000 credits in a random round isn't going to break the game.

Unrelated, but any idea why the linters check is failing? Having trouble making sense of that error.

@Kurfursten
Copy link
Collaborator

Yes, because on Line 16 of Lotto.dm you accidentally put in /proc before your object's path

You can click on the "Details" to the right of the failed test to see the compile failure report.

@Kurfursten
Copy link
Collaborator

The more I think about it, the more I question whether the supermatter joke item is a good idea. I feel like this is a bit of a newbie trap. Not just for the first person who buys it, but all the random new players wandering the halls who see a ticket laying on the ground and lose a hand instantly. Supermatter shards are not easily accessible, and they're both named and described in ways that make their danger apparent. This is intentionally named and described to encourage random players to pick it up and lose a hand. If someone told you to bite a supermatter shard, that would immediately sound like a bad idea to anyone. If someone told you "hey, try scratching this off by biting it" someone might actually do that and end up round removed.

How about this?

  • You are guaranteed to receive some payout (e.g.: the smallest prize you can win is 20 credits)
  • But scratching it off gives you a big burst of rads
  • And holding it passively gives a small amount of rads (like the supermatter beaker)

Just an alternate, slightly health-dangerous lotto.

@Eneocho
Copy link
Collaborator

Eneocho commented Feb 4, 2022

The supermatter ticket should interact with SASS and FRASS spheres as well.

@west3436
Copy link
Collaborator Author

west3436 commented Feb 5, 2022

Sounds like a good idea, I can work on that.

The supermatter ticket should interact with SASS and FRASS spheres as well.

It already does; I shamelessly copy-pasted the supermatter splinter code for it.

@Theophrastus1
Copy link

Great next we're gonna have smoke shops and liquor stores on every corner

you are singlehandedly driving property values down

@west3436
Copy link
Collaborator Author

west3436 commented Feb 5, 2022

Great next we're gonna have smoke shops and liquor stores on every corner

you are singlehandedly driving property values down

It's all coming together

@Eneocho
Copy link
Collaborator

Eneocho commented Feb 6, 2022

Can you avoid the supermatter surprise eye damage with flash-resistant glasses or mesons? If not, make it avoidable with mesons since you avoid the SME hallucinations with mesons.

@Eneocho
Copy link
Collaborator

Eneocho commented Feb 6, 2022

+15,673 −1,629,860

Did you delete the full map somehow?

Copy link
Collaborator

@Kurfursten Kurfursten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deleted all fire alarms and newscasters off Boxstation. While this is based, it is unatomic.

@west3436
Copy link
Collaborator Author

west3436 commented Feb 6, 2022

You deleted all fire alarms and newscasters off Boxstation. While this is based, it is unatomic.

Whoops, haven't quite learned how to map properly yet. I'll just save mapping these in for a later PR.

@west3436
Copy link
Collaborator Author

west3436 commented Feb 6, 2022

Can you avoid the supermatter surprise eye damage with flash-resistant glasses or mesons? If not, make it avoidable with mesons since you avoid the SME hallucinations with mesons.

It doesn't cause eye damage. It's the same effect as a blinder flash but with a much smaller radius. The lines mentioning eye damage just give a unique wording to people who already have some eye damage.

@west3436
Copy link
Collaborator Author

west3436 commented Feb 6, 2022

Hearing silence on better sprites, this is good to go now. If better sprites are provided, I can add them down the line as part of the PR which will map these into the bars.

@west3436 west3436 marked this pull request as ready for review February 6, 2022 18:29
@west3436
Copy link
Collaborator Author

west3436 commented Feb 6, 2022

Is the vending machine moveable or is it like the snowflakey vox "vending" that the outpost has?

It's just a normal vending machine.

code/game/machinery/computer/cargo.dm Outdated Show resolved Hide resolved
code/game/machinery/computer/cargo.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Show resolved Hide resolved
code/modules/games/cards/lotto.dm Outdated Show resolved Hide resolved
code/modules/games/cards/lotto.dm Outdated Show resolved Hide resolved
code/modules/games/cards/lotto.dm Outdated Show resolved Hide resolved
code/modules/games/cards/lotto.dm Show resolved Hide resolved
code/modules/games/cards/lotto.dm Outdated Show resolved Hide resolved
code/modules/games/cards/lotto.dm Outdated Show resolved Hide resolved
code/modules/games/cards/lotto.dm Outdated Show resolved Hide resolved
@adacovsk
Copy link
Contributor

adacovsk commented Feb 7, 2022

Have it announce the winner using the old money_lotto.dm code

@Kurfursten
Copy link
Collaborator

The man is right

@west3436
Copy link
Collaborator Author

holy shit im being BTFO'd by git rn

code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/modules/games/cards/lotto.dm Outdated Show resolved Hide resolved
code/modules/games/cards/lotto.dm Show resolved Hide resolved
code/modules/games/cards/lotto.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@DamianX DamianX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's intended that you can attack the supermatter ticket with any other item to trigger it. Did you mean to make it flash only when it's scratched with a sharp object or coin?

code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/modules/games/cards/lotto.dm Outdated Show resolved Hide resolved
@west3436
Copy link
Collaborator Author

I don't think it's intended that you can attack the supermatter ticket with any other item to trigger it. Did you mean to make it flash only when it's scratched with a sharp object or coin?

fixed in latest commit



/obj/item/toy/lotto_ticket/attackby(obj/item/weapon/S, mob/user)
if(!revealed)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel as if an early return would be good here, so go straight to the

to_chat(user, "The film covering the prizes has already been scratched off.")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? If !revealed is false (meaning it was already scratched off) then the associated else produces

to_chat(user, "The film covering the prizes has already been scratched off.")

@DamianX DamianX merged commit 7129d48 into vgstation-coders:Bleeding-Edge Feb 18, 2022
@west3436 west3436 deleted the lotto branch February 28, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants