Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotto Ticket Updates #32120

Merged
merged 7 commits into from
Feb 24, 2022
Merged

Conversation

west3436
Copy link
Collaborator

@west3436 west3436 commented Feb 22, 2022

List of changes:

  • Lotto vendors now announce winners of >10,000 credits to the crew via common chat.
  • Hacked vendors will now only shoot paper (unprinted tickets heh) instead of free lotto tickets.
  • Adds cargo resupply pack.

🆑

  • rscadd: lotto vendors now announce winners to the entire station.
  • rscdel: removed ability to hack the lotto vendor to shoot free tickets.

@PJBot PJBot added the Mapping (General 🗺️) This applies to every map really. label Feb 22, 2022
@west3436
Copy link
Collaborator Author

oh no
image

@west3436 west3436 marked this pull request as draft February 22, 2022 15:48
@adacovsk
Copy link
Contributor

too unatomic imo

@Theophrastus1
Copy link

MOM HE DELETED BOX AGAIN

@west3436 west3436 changed the title Lotto Vendor Mapping & Updates Lotto Ticket Updates Feb 22, 2022
@west3436 west3436 marked this pull request as ready for review February 22, 2022 16:01
@west3436 west3436 mentioned this pull request Feb 22, 2022
@adacovsk
Copy link
Contributor

should let it be emagged though

@west3436
Copy link
Collaborator Author

should let it be emagged though

Emagging it makes the Supermatter Surprise ticket available just as hacking it does. This just changes the shooting item to be paper instead of tickets.

@Eneocho
Copy link
Collaborator

Eneocho commented Feb 22, 2022

rscdel: removed ability to hack the lotto vendor to shoot free tickets.

Come on man, you're going down the route of the snowflake voxvendor. Don't remove the ability to hack for free items. Free item hack takes a lot longer to spit a decent amount of items, so you're trading money for time. Let us have the thing hackable that way.

@west3436
Copy link
Collaborator Author

rscdel: removed ability to hack the lotto vendor to shoot free tickets.

Come on man, you're going down the route of the snowflake voxvendor. Don't remove the ability to hack for free items. Free item hack takes a lot longer to spit a decent amount of items, so you're trading money for time. Let us have the thing hackable that way.

There is no way to hack the slot machine to be free. Taking the cost away from any form of lottery item is just free money. People can get around having to wait by simply making 20 of these vendors (trivial as a Mechanic) and placing a monkey in a chair in the center.

@Eneocho
Copy link
Collaborator

Eneocho commented Feb 23, 2022

But that setup would take some effort which would be worth the reward, besides, it's not like money actually has an use in game (spessmart does not count).

@west3436
Copy link
Collaborator Author

west3436 commented Feb 23, 2022

But that setup would take some effort which would be worth the reward

Lmao dude scanning a machine then feeding the flat pack printer roundstart materials is not a lot of setup.

besides, it's not like money actually has an use in game (spessmart does not count).

Moving the goalposts. The new money leaderboard is a great reason to make credits have some sanity.

@Eneocho
Copy link
Collaborator

Eneocho commented Feb 23, 2022

I honestly forgot the leaderboard was actually a thing, since I'm so used to it be fucked with the turbo exploits/metaclub vault credits.
I'll concede, though I still dislike the snowflake code.

@gurfan
Copy link
Contributor

gurfan commented Feb 23, 2022

Come on man, you're going down the route of the snowflake voxvendor. Don't remove the ability to hack for free items. Free item hack takes a lot longer to spit a decent amount of items, so you're trading money for time. Let us have the thing hackable that way.

no, fuck off

@Eneocho
Copy link
Collaborator

Eneocho commented Feb 23, 2022

no, fuck off

You're 20 hours late to the point, man.

@Kurfursten Kurfursten merged commit 84be608 into vgstation-coders:Bleeding-Edge Feb 24, 2022
@Kurfursten
Copy link
Collaborator

Kurfursten commented Feb 24, 2022

it's not like money actually has an use in game (spessmart does not count).

This just creates more barriers for money to have a use. Over the years we have slowly added more and more features where money does matter. Merch computer (back in N3X days), spessmart, traders, old vendotron event (and yes, the OG cargo console), and the scoreboard. Hopefully we will some day reach the point where people DO have a desire for money, so let's not add infinite lotto exploits. Besides, this is consistent with the one armed bandit being unhackable.

You're also using snowflake wrong. Snowflake isn't just used to describe any feature that differs from other features. For example, it's not snowflaking when you make the esword able to cut through walls unlike other melee weapons. Snowflaking is when you code something in a non-OOP way. But he properly used throw_item() to make this change OOP. The trader window is also not snowflaking -- it's even less snowflaking, because it's an entirely different object that works in unrelated way. For example, sunglasses are not """snowflaked""" from headwear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping (General 🗺️) This applies to every map really.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants