fix shift duration timestamp in join game menu and check antags menu #36447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -525,7 +521,7 @@ | |||
| .manifest tr.requested_department td {background-color: #00FF00} | |||
| .manifest th.reqhead td {background-color: #844} | |||
| .manifest tr.reqalt td {background-color: #FCC} | |||
| </style></head><body><center>Round Duration: [round(hours)]h [round(mins)]m<br>"} | |||
There was a problem hiding this comment.
Undocumented text change from round to shift
There was a problem hiding this comment.
Not nearly significant enough for a changelog entry.
west3436
approved these changes
May 6, 2024
|
This bugfix changes server-standard verbiage incorrectly - our codebase uses Round as the correct noun to describe the game's duration. This is used in multiple places throughout the code, notably in Dynamic as a description for when antagonists fire. Shift is not used in the code at any point, though many players use the term to talk about the concept in an in character sense. That said, I personally don't actually care enough to not merge a useful bugfix. If someone else does care they can make a PR to change it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
title
Why it's good
currently it displays the time since init finished, which is incorrect
[bugfix]
Changelog
🆑