Pull Request Template Changes #36473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitak
added
the
System
UMM YOU DIDN'T TEST THIS PR??? Closing as it didn't follow basic testing, PRs have fallen; billions must test. |
😂😂😂😂😂😂😂😂😂😂 |
|
Annoying to have to delete that section in addition to the "Why it's good" one every time tbh |
west3436
added
the
0% tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template updates for future PRs? I'm sure ready for people to ignore them! Please place your comments below on any possible changes to this template while we're here.
What this does
Changes the default template for Github Pull Requests, adding an additional field to explain how it was tested, and adding some additional clarifiying comments.
Why it's good
Provides a dedicated section to explain what tests a PR may have done beforehand, helping collabs and other code reviewers find missed tests and squash bugs before the code is merged.
How it was tested
it wasn't
Changelog
Github system changes, no CL needed.