Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk order empty lunchboxes from Cargo #36582

Merged

Conversation

JonathanSpaceStation
Copy link
Contributor

What this does

Adds two new crates which can be ordered from cargo. One contains five empty, standard lunchboxes for 25 credits. The other contains five empty collectable lunchboxes at a cost of 50.

Why it's good

Think this is a nice addition for any chef who wants to do a lunchbox gimmick. Normally you get collectable lunchboxes from the merch vendor one at a time, but this just gives you another method of getting them in bulk.

Changelog

馃啈

  • rscadd: Can now bulk order empty lunchboxes (standard and collectable) from cargo.

@west3436 west3436 added 0% tested What could possibly go wrong / Try again after testing it. Fluff 馃Ц How uselessly cute. labels May 24, 2024
@jwhitak
Copy link
Collaborator

jwhitak commented May 24, 2024

Too expensive for too few boxes imo.

@west3436 west3436 added 100% tested I promise I tested it every possible way / HAHA HE PROMISED HE TESTED IT AND DIDN'T and removed 0% tested What could possibly go wrong / Try again after testing it. labels May 24, 2024
@JonathanSpaceStation
Copy link
Contributor Author

collectable ones are already 10 credits per from the merch console, so 50 for 5 is inline with existing pricing. Could make the generic ones cheaper I guess but I think its fine as is.

@jwhitak
Copy link
Collaborator

jwhitak commented Jun 1, 2024

Only issue I might have with the code is that you're using the randomized cargo crates for a single object type (which self-randomizes) but should all be good.

@jwhitak jwhitak merged commit a747ef8 into vgstation-coders:Bleeding-Edge Jun 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
100% tested I promise I tested it every possible way / HAHA HE PROMISED HE TESTED IT AND DIDN'T Fluff 馃Ц How uselessly cute.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants