-
Notifications
You must be signed in to change notification settings - Fork 540
Tagging guidelines
This is a guide on what tags mean and when to apply them.
##Tags In alphabetical order:
Hahaha they didn't test shit.
This tag belongs on any PR which changes the game balance of an item, ability, system, etc. It doesn't necessarily need to be balance regarding player vs. player interactions, it can be as simple as 'makes the autolathe faster'. Note that the addition of new content can have balance implications as well. Discussions about game balance also should have this tag.
When an error in the code was causing something to not work properly. If the code works OK, but it still probably should be changed for gameplay reasons anyways, then it's probably an Oversight.
This PR is conflicting with another PR or commit that has already been pushed and cannot be merged until the conflicts are resolved.
This is mainly used where there's two similar systems/objects but one is missing a behavior expected of it since the other has it.
Adds something new!
This tag should be applied to any PR or issue that the community cannot agree about. Best applied after the controversy shows itself, not before: you don't always know how the community will react to a change.
This tag should be used primarily on issues which are the basis for discussions such as brainstorming or gathering feedback. Also used for PRs that turn into debates.
This tag is used to describe PRs that have flaws that should prevent them from being merged before they are fixed. Also used for PRs that were submitted as works in progress.
This is applied to issues that someone who is just starting out at coding on BYOND should be able to figure out fairly simply, albeit possibly with a bit of help if they're new to coding altogether.
As-is, the issue described or something added in the PR is exploitable by malcontents in the playerbase. Needs fixing ASAP.
Something that used to be there but is now gone or doesn't work anymore. Often goes with Bug/Fix. Also used for PRs that remove a feature for whatever reason.
Something that someone is asking be coded that likely doesn't exist yet. Replaced by the tag "WYCI" when it applies.
Bringing code up to standards without actually changing anything (or much, depending on what's changing) on the game side of things. Can also be applied to someone sorting DMIs by icon_state or whatever.
This tag applies primarily to PRs that alter the overarching design of the game (economy, departmental overhauls/additions/removals)
Complains about words (issues) or changes words (PR). Also applies to changes in formatting, such as changing text from red to red and bold.
Honk.
Fixes something that isn't quite what it was expected to be when it was pushed recently.
Something that may or may not stay around even if it may not make logical sense. Also known as "too funny to fix".
Anything that involves game logging or administration tools.
Modifies / Requests modification of the named map.
Modifies every major map we actually use, or requests that something be changed on them all. Please apply WITH the individually named maps for purposes of tag searching. Can also be used on something that modifies maps that don't fit any other category, such as a new one.
This PR needs to be merged before anything else that touches the maps so that they don't have to deal with conflict hell.
Someone's immersions were shattered, oh dear.
Largely redundant with Do Not Merge, mainly useful for things like WIP PRs.
If applied to an issue, then it's unclear as to the cause. If it's applied to a PR, clearly it needs to be tested more before being merged to ensure that it actually functions.
Someone didn't give much information at all when they made an issue. Also used for PRs that don't give much information on the thing they're adding/changing. If you're making a sprite or content PR and don't include at least one picture, expect to be slapped with this tag.
This tag describes PRs that need code review by one or more experienced coders to check for flaws in the code itself.
Spriters, assemble!
The issue isn't a bug. However, it may still need fixing or adjustment.
FIXITFIXITFIXITFIXITFIXITFIXITFIXITFIXITFIXITFIXITFIXITFIXIT All issues regarding Poly the Parrot must also be tagged with this.
Issues with this tag involve cases where the code is functioning correctly but interaction of objects is producing emergent bad behavior that should be fixed.
Bugs are code issues - they can be anything from poorly written logic to a lack of sanity, but they mean that the code doesn't do what the writer expects it to.
Oversights are not caused by bad code - they are caused by code interaction, when two systems come together to do something that we expect in each system, but together are an issue.
Either negatively or positively impacts performance of the server.
This was taken from another server.
Making things better for everyone.
An admin needs to run a server vote and figure out what the playerbase thinks about this change.
Issues with this tag document runtimes with included runtime logs. It's perfectly fine to also tag PRs that fix said issues with this.
Someone can do something they shouldn't be able to.
Someone with secret repo access will have to update the secret repo after this is merged in order for it to function correctly. This tag will AUTOMATICALLY be applied by PJB's bot, however please remove it (even after the PR is merged) when you resolve the conflict.
Pew pew.
Pretty colors.
This means something that works behind the scenes. This may or may not affect the average player when modified.
This'll take a lot of work to work around, or it's probably unfixable. T-Thanks BYOND!
This means the things you can see that aren't IC, such as your inventory, HUDs, health, etc.
Someone can't reliably reproduce this issue when they follow the steps provided. Expect it to get closed soon.
Feature requests over a year old that no one showed any interest in coding, have been fulfilled without realizing the issue existed, or are no longer relevant to the server.
Update the wiki either before or after the merge.
When You Code It. A feature request that would require a massive amount of work or is probably too niche to expect anyone else to code it except you. Basically, an "ideas guy" feature request.