Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not relocate the tape elements #793

Open
vgvassilev opened this issue Mar 3, 2024 · 1 comment
Open

Do not relocate the tape elements #793

vgvassilev opened this issue Mar 3, 2024 · 1 comment
Labels
good first issue

Comments

@vgvassilev
Copy link
Owner

In the current implementation of clad::tape we ensure the elements are contiguous. The grow operation relocates the elements when the size exceeds the tape capacity:

clad/include/clad/Differentiator/Tape.h

Line 119 in f242077

CUDA_HOST_DEVICE void grow() {

Instead we should allocate slabs of 32 or 64 elements and the last element should point to the next slab.
@MashyBasker MashyBasker mentioned this issue Mar 4, 2024
Closed
Deepanshu9376 added a commit to Deepanshu9376/clad that referenced this issue Mar 21, 2024
@Deepanshu9376
Update Tape.h issue vgvassilev#793
e534199
@Deepanshu9376
Copy link

Hey @vgvassilev I have made some changes to resolve this. check that branch once

Deepanshu9376 added a commit to Deepanshu9376/clad that referenced this issue Mar 21, 2024
@Deepanshu9376
Merge pull request #1 from Deepanshu9376/Deepanshu9376-patch-1
1242471 
Update Tape.h issue vgvassilev#793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use struct Slab in grow() so that tape elements do not relocate MashyBasker/clad
2 participants
@vgvassilev @Deepanshu9376