Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smear test #400

Closed
wants to merge 23 commits into from
Closed

Smear test #400

wants to merge 23 commits into from

Conversation

bianchini
Copy link

Add EGamma smearing to vhbb workflow and switched to calibratedPatElectrons in place of slimmedElectrons.

matteosan1 and others added 23 commits February 11, 2016 15:24
@matteosan1
cleaning commits
89b2eb9
@matteosan1
Merged test from repository matteosan1
3945d55
@matteosan1
Merged smearer_76X from repository matteosan1
d3b2bdf
@ferriff @matteosan1
ongoing developments
a81d4d0
@matteosan1
few changes from constTerm, alpha to rho, phi
4cc4bb6
@ferriff @matteosan1
update smearing systematics to return a variation of nSigma (for rho …
750c0d3 
…and phi independently)
@matteosan1
Merged smearer_76X_test from repository matteosan1
48b060b
@ferriff @matteosan1
add run 1-254789 categories (for not getting complaints when running …
bda220e 
…on MC)
@ferriff @matteosan1
change interface to have coherent argument ordering for scales and sm…
429727b 
…earings methods, always pass Et; improve debugging printouts
@ferriff @matteosan1
adapt to interface changes in EnergyScaleCorrection_class
1d72e38
@matteosan1
Merged smearer_76X_test from repository matteosan1
24f2bc3
@matteosan1
updates to scale and smearings for photon, just .dat files
f99a4e4
@emanueledimarco
make it working when used in python
6519f63
@emanueledimarco
* fix the R9 to the full5x5 version
d1b5038 
* fix a possible unreasonable correction when not in a known class
@emanueledimarco
add the photon offline scale/resolution corrections
3225e53
@emanueledimarco
- remove unusued dat file
8db38ea 
- update the scale and smearings to 76X re-reco
@emanueledimarco
remove spurious cout
a9405a3
@emanueledimarco
Revert "add the photon offline scale/resolution corrections"
4526417 
This reverts commit 3225e53.
@matteosan1
Merge pull request cms-sw#6 from emanueledimarco/smear_76X
6a91f89 
Updates discussed in the office
@emanueledimarco
technical change to allow Hgg to take systematics for the MC from the…
0c03372 
… same file
@matteosan1
Merge pull request cms-sw#7 from emanueledimarco/smear_76X
9b045ed 
Small technical change for Hgg systematics
@bianchini
Merged v21fixes from repository arizzi
3e67f1a 
Conflicts:
	EgammaAnalysis/ElectronTools/interface/ElectronEnergyCalibratorRun2.h
	EgammaAnalysis/ElectronTools/interface/PhotonEnergyCalibratorRun2.h
	EgammaAnalysis/ElectronTools/interface/SimpleElectron.h
	EgammaAnalysis/ElectronTools/plugins/CalibratedElectronProducersRun2.cc
	EgammaAnalysis/ElectronTools/plugins/CalibratedPhotonProducersRun2.cc
	EgammaAnalysis/ElectronTools/python/calibratedElectronsRun2_cfi.py
	EgammaAnalysis/ElectronTools/python/calibratedPhotonsRun2_cfi.py
	EgammaAnalysis/ElectronTools/src/ElectronEnergyCalibratorRun2.cc
	EgammaAnalysis/ElectronTools/src/PhotonEnergyCalibratorRun2.cc
	EgammaAnalysis/ElectronTools/src/SimpleElectron.cc
	EgammaAnalysis/ElectronTools/src/SimplePhoton.cc
	EgammaAnalysis/ElectronTools/src/classes.h
	EgammaAnalysis/ElectronTools/src/classes_def.xml
	EgammaAnalysis/ElectronTools/test/testCalibratedPatElectronProducerRun2_cfg.py
@bianchini
switched to smeared electrons
ef66ab7
@bianchini
Copy link
Author

Ciao, that's what I did to get the smearing. I am not 100% confident with switching to smeared electrons... I am not sure what happens to ele ID for example. Ideal would be to have standard electrons in vLeptons, and then a branch vLeptons_pt_smear or so, but would require some extra work..

@arizzi
Copy link

arizzi commented Mar 11, 2016

175 changed files? is it because it is based on a 763 rather than 763patch2 ? or what?

Can you rebase on today's head?

@bianchini
Copy link
Author

Ciao, boh, I based it on your v21fixes branch and 763p2..
I will try to rebase it.

@arizzi
Copy link

arizzi commented Mar 11, 2016

wait before rebasing
the HEAD is being messed up

@arizzi
Copy link

arizzi commented Mar 11, 2016

now it is ok, can you try the rebase?

@bianchini
Copy link
Author

Ciao, ok, thanks.
Actually, I figured out that Heppy has already this feature in:
https://github.com/vhbb/cmssw/blob/vhbbHeppy76X/PhysicsTools/Heppy/python/physicsutils/ElectronCalibrator.py
But I am not sure it has been updated for 76X. I asked to @matteosan1 @gpetruc

@bianchini
Copy link
Author

@emanueledimarco: Marco (Peruzzi) told me that you have update it in Heppy..

@emanueledimarco
Copy link

@bianchini @arizzi Yes. This was done with the PR #622 merged by Giovanni this week.
The number of commits is large because the EgammaAnalysisTools was based on a CMSSW_7_6_3_patch2.
The updated scale and resolution corrections for 76X can be propagated to the electron or photon object setting "doPhotonScaleCorrections=True" in the PhotonAnalyzer (and similar for the ElectronAnalyzer that Giovanni implemented before).

And yes, it is the latest version of the branch 76X of @matteosan1 repo, which also includes some small fixes.

@arizzi
Copy link

arizzi commented Mar 11, 2016

is it included here?
cbernet#69

@emanueledimarco
Copy link

@arizzi Yes, it is included.

@arizzi
Copy link

arizzi commented Mar 11, 2016

@bianchini let's see if colin merges it first, then we merge from there or otherwise we can just merge that into our branch ourselves

@arizzi arizzi mentioned this pull request Mar 14, 2016
Merged
@bianchini bianchini closed this Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bianchini @arizzi @emanueledimarco @matteosan1 @ferriff