Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

[READY] Add --log option to set logging level #15

Merged
merged 1 commit into from
Jun 2, 2016
Merged

[READY] Add --log option to set logging level #15

merged 1 commit into from
Jun 2, 2016

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented Jun 1, 2016

Without this option, we can't see the logs with debug level. Also, we need this to pass the ycmd logging level to JediHTTP.

This is mostly copied from ycmd.


This change is Reviewable

@vheon
Copy link
Owner

vheon commented Jun 2, 2016

:lgtm: @homu r+

Previously, micbou wrote…

[READY] Add --log option to set logging level

Without this option, we can't see the logs with debug level. Also, we need this to pass the ycmd logging level to JediHTTP.

This is mostly copied from ycmd.


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@homu
Copy link
Collaborator

homu commented Jun 2, 2016

📌 Commit e955b9b has been approved by vheon

@homu
Copy link
Collaborator

homu commented Jun 2, 2016

⚡ Test exempted - status

homu pushed a commit that referenced this pull request Jun 2, 2016
Pull request: #15
Approved by: vheon
@homu homu merged commit e955b9b into vheon:master Jun 2, 2016
homu added a commit to ycm-core/ycmd that referenced this pull request Jun 2, 2016
[READY] Pass ycmd logging level to JediHTTP

Now that [`JediHTTP` has an option to set its logging level](vheon/JediHTTP#15), we can pass `ycmd` logging level to it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/513)
<!-- Reviewable:end -->
homu added a commit to ycm-core/ycmd that referenced this pull request Jun 3, 2016
[READY] Pass ycmd logging level to JediHTTP

Now that [`JediHTTP` has an option to set its logging level](vheon/JediHTTP#15), we can pass `ycmd` logging level to it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/513)
<!-- Reviewable:end -->
@micbou micbou deleted the log-level branch June 15, 2016 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants