Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize structure of setup_tool's module #881

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

leokondrashov
Copy link
Contributor

Summary

The way setup_tool's code was organized conflicted with VS Code and was too fine grained (each subfolder is a separate module)

Implementation Notes ⚒️

  • Single module for the whole setup_tool, added to workspace config. VS code handles the code now.

External Dependencies 🍀

  • N/A

Breaking API Changes ⚠️

  • N/A

Signed-off-by: Leonid Kondrashov <leo.kondrashov@gmail.com>
Copy link
Collaborator

@lrq619 lrq619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@leokondrashov leokondrashov merged commit 632bc40 into main Nov 16, 2023
22 checks passed
@leokondrashov leokondrashov deleted the setup-tool-reorg branch November 16, 2023 02:11
@lrq619 lrq619 mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants