Deploying Openyurt on top of kubernetes & knative #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchua99
force-pushed
the
openyurt-deploy
branch
3 times, most recently
from
bdc0839
to
5e29798
Compare
jchua99
force-pushed
the
openyurt-deploy
branch
5 times, most recently
from
999853b
to
72eb921
Compare
ustiugov
reviewed
Dec 13, 2023
jchua99
force-pushed
the
openyurt-deploy
branch
3 times, most recently
from
fcee46d
to
a400526
Compare
|
Please add me as the reviewer, also, you only have two added checks here, but it should pass through all tests that was previously there |
jchua99
force-pushed
the
openyurt-deploy
branch
6 times, most recently
from
9a73816
to
425a26e
Compare
lrq619
reviewed
Dec 21, 2023
ustiugov
requested changes
Dec 21, 2023
There was a problem hiding this comment.
- use Golang 1.19 everywhere. we should update it later to 1.20 but in a different PR
- add the vHive copyrights to all the source files
- I suggest making the whole deployer a single Golang module to make our life easier in future. We don't need moule versioning at this fine granularity. vHive can be a good example: it's a single module despite the folder structure. I suggesting having 1 module for vHive and 1 for deployer. No need for other modules, too complicated.
- remove binaries from the commit history (prune it! not just remove in a new commit)
- remove the YAML files duplication in golang files (I see 2 cases).
jchua99
force-pushed
the
openyurt-deploy
branch
2 times, most recently
from
4c83dbc
to
9b9204b
Compare
unit test with github workflows change template to yaml Signed-off-by: Jason Chua <chua0990@e.ntu.edu.sg>
jchua99
force-pushed
the
openyurt-deploy
branch
from
9b9204b
to
7bb8cd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deploying openyurt on top of initial configs of k8s and knative.
To run, go build and ./openyurt_deployer deploy-yurt.
Implementation Notes ⚒️
External Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.