Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create prepare_one_node_cluster command #972

Merged

Conversation

wanghanchengchn
Copy link
Contributor

Summary

To better support the deployment and management of single-node Kubernetes clusters, I have created a new command prepare_one_node_cluster. Previously, the create_one_node_cluster command was responsible for both preparing the single-node environment and setting up the master node. Now, I have added a new command called prepare_one_node_cluster. With this new command, users can first prepare the single-node environment, and then manually run setup_master_node to set up the master node when needed. This increased flexibility enables users to selectively execute the relevant steps based on their specific needs.

Implementation Notes ⚒️

First, I have split the create_one_node_cluster command into two parts: preparing the single-node environment and setting up the master node. Note that I have only divided the previous create_one_node_cluster command into two functions, without affecting the functionality of the original create_one_node_cluster command.

Subsequently, I have created the prepare_one_node_cluster command, which only runs the first part of the create_one_node_cluster command, i.e., the part responsible for preparing the single-node environment. After running the prepare_one_node_cluster command, users can manually call the setup_master_node command when they need to.

External Dependencies 🍀

N/A

Breaking API Changes ⚠️

N/A

@leokondrashov leokondrashov requested review from lrq619 and removed request for leokondrashov April 12, 2024 07:01
@lrq619
Copy link
Collaborator

lrq619 commented Apr 18, 2024

Hi hancheng, please pass the unit test there

lrq619
lrq619 previously approved these changes Apr 18, 2024
@JooyoungPark73
Copy link
Contributor

The reason why runner is failing is because we use create one node cluster on other function.

if err := cluster.CreateOneNodeCluster(sandbox); err != nil {

Please add setup master node there and re-run the checks.

@wanghanchengchn wanghanchengchn force-pushed the hancheng/single_node_affinity branch 3 times, most recently from 60fde8d to f0cbf36 Compare April 18, 2024 11:43
lrq619
lrq619 previously approved these changes Apr 20, 2024
Copy link
Collaborator

@lrq619 lrq619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on the main branch and check if all checks are passed

@wanghanchengchn wanghanchengchn force-pushed the hancheng/single_node_affinity branch 5 times, most recently from a544da3 to f0cbf36 Compare April 21, 2024 04:12
Signed-off-by: hancheng wang <wanghanchengchn@gmail.com>

solve the label issue of singlenode through affinity

Signed-off-by: hancheng wang <wanghanchengchn@gmail.com>
Copy link
Collaborator

@lrq619 lrq619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@lrq619 lrq619 merged commit 532496d into vhive-serverless:main Apr 24, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants