Ops 508 - Send notifications of codebuild job status changes. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alboyadjian
force-pushed
the
ops-508
branch
3 times, most recently
from
50af6ba
to
dacbe34
Compare
|
@davexunit Do you think it's worth breaking this up from a big-ass procedural script to ruby classes right now? Or should we wait till we've run it in the wild a little? |
davexunit
requested changes
Nov 13, 2018
bin/update-build-status
Outdated
| end | ||
|
|
||
| def secrets_manager_slack_secret_name | ||
| ENV['CB_NOTIFIER_SLACK_SECRET_NAME'] || 'slack/code-build' |
There was a problem hiding this comment.
Style nit: "codebuild", one word, no dash.
bin/update-build-status
Outdated
| table_name: dynamo_table_name | ||
| ) | ||
|
|
||
| unless old_status != current_status |
There was a problem hiding this comment.
Replace double negative: if old_status == current_status
bin/update-build-status
Outdated
| author_name = git_info[1] | ||
| author_email = git_info[2] | ||
| committer_email = git_info[3] | ||
| commit_subject = git_info[4] |
There was a problem hiding this comment.
short_hash, author_name, author_email, committer_email, commit_subject = git_info
bin/update-build-status
Outdated
| unless lookup_response.ok | ||
| cb_puts "Slack user lookup by email for #{email} failed with " \ | ||
| "error: #{lookup_response.error}" | ||
| next |
There was a problem hiding this comment.
Instead of using next, use if/else and incorporate the rest of the code after the unless block.
davexunit
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.