fix: simplify project dependencies, fix tests

[vit-zikmund]

Hello Vojtěchu ;) @vhyza,

My colleagues and I tried to experiment with your plugin, but realized the last published version is too old for our ES instance. Despite not being a java guy at all, I decided to give a custom build a try. Following your instructions to run mvn package indeed produced a .zip package, but the test was throwing an exception that was pretty impossible to decipher. I didn't feel like ignoring that and decided to make it work. There were some hints on the internet, that the dependencies might be clashing, so I tried to untangle them. I spend some non-trivial time on that and found those could be really simplified quite a bit. The ultimate fix was to bump the maven-surefire-plugin, though 😮‍💨

Going through all this - and succeeding - I thought I might share the result with you. I actually also found quite useful the contribution from @crabhi, which allowed me to write a very similar building Dockerfile, that dynamically sets both the (plugin.version replaced by) project.version and the targeted elasticsearch.version:

ARG elasticsearch_version=8.7.1
FROM maven:3-eclipse-temurin-17-alpine as lemmagen
ARG elasticsearch_version
# we need a non-root user for the plugin tests to pass
RUN adduser -s /sbin/nologin -D builder
USER builder
# prevent access error in case of running this (otherwise ephemeral) image as a non-root user
ENV MAVEN_CONFIG=/home/builder/.m2
WORKDIR /home/builder/elasticsearch-analysis-lemmagen

COPY --chown=builder:builder . ./
RUN set -eu ;\
    mvn --no-transfer-progress versions:set -DnewVersion=$elasticsearch_version ;\
    mvn --no-transfer-progress package -Delasticsearch.version=$elasticsearch_version

With all that I'd like to thank you for sharing your code with the open source community, so we can all take part.

[vhyza]

Hi @vit-zikmund,

thank you for the PR. I'm sorry I didn't get back to you sooner. I'm quite swamped with other projects and as I do not use the plugin for years now, my motivation is not the strongest.

Anyway, I'd like to get back one day, but it will probably take some more time. I'm sorry about that.

[vit-zikmund]

Hi @vhyza, what a nice surprise you're even still there! 👍 TBH, we didn't push it much further ourselves...

While we made it build/bundle for whatever ES version we desire, on using it, we discovered once the plugin gets used it throws some banal permissions error coming from log4j that likley needs some whitelisting somewhere. Maybe some policy file or what. But the Java docs about AccessController are dense as Java world can be for an outsider like me, and ES even dropped their plugin dev docs for the later versions. It seems we're 🤏 this close to figure it out, but then we get swamped with other stuff too...

So out of sheer joy of sharing I'm pasting it here, if you'd (or anyone) know where to go:

java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "getClassLoader")
    at java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:488)
    at java.base/java.security.AccessController.checkPermission(AccessController.java:1071)
    at java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:411)
    at java.base/java.lang.ClassLoader.checkClassLoaderPermission(ClassLoader.java:2070)
    at java.base/java.lang.Thread.getContextClassLoader(Thread.java:2384)
    at org.slf4j.impl.SimpleLoggerConfiguration$1.run(SimpleLoggerConfiguration.java:102)
    at org.slf4j.impl.SimpleLoggerConfiguration$1.run(SimpleLoggerConfiguration.java:100)
    at java.base/java.security.AccessController.doPrivileged(AccessController.java:319)
    at org.slf4j.impl.SimpleLoggerConfiguration.loadProperties(SimpleLoggerConfiguration.java:100)
    ...

Thank you once again and take it easy :)