Add Portuguese and DynamicFormatter

[ghost]

This adds Português-BR (I'm native speaker). I'm grateful if you could publish it on crates.io.

I just added a DynamicFormatter too, which uses runtime Language. Now, Formatter wraps a DynamicFormatter.

[vi]

Does this bump MSRV? Currently it's 1.24.1.

[ghost]

Just bumped the MSRV.

[vi]

Published 0.2.2 with the new language, but without other changes.

Are you use the remaining changes are semver-compatible? Maybe they need 0.3.0?
Shall this dyn-clone be optional dependency?

[ghost]

The DynamicFormatter was going to break compatibility a bit. I'll end up forking it again. I was needing to use Formatter in my localization crate, however the problem is that timeago::Formatter structure is parameterized <L>, I need to hold a Formatter with any Language at runtime.

[vi]

my localization crate

Is it public? Maybe timeago can be integrated more closely into it?

the problem is that timeago::Formatter structure is parameterized , I need to hold a Formatter with any Language at runtime.

What's wrong with just Formatter<Box<Language>>?
Supplied executable example uses it to dynamically switch languages.

Cloning can be supplemented with just a minor change. Send+Sync - not sure, maybe with a version bump.

[ghost]

Thanks, I didn't know it could use a Box<dyn Language> as argument. Clone would still be needed if there were moves, but the Language structure is immutable, so I think it's good as is. I'll try using it in my crate.

[vi]

Pushed to master a version with impl Clone for Formatter<BoxedLanguage> (but not yet to crates.io).

Is this OK for you?

[ghost]

Using the current GitHub version gives this error:

struct S {
    // the trait bound `std::boxed::Box<(dyn timeago::Language + 'static)>: timeago::Language` is not satisfied
    // the following implementations were found:
    // <std::boxed::Box<(dyn timeago::Language + Send + Sync + 'static)> as timeago::Language>
    _current_timeago_formatter: Option<Rc<timeago::Formatter<Box<dyn timeago::Language>>>>,
}

It'd be complicated to add 'static to Box<dyn Language>. I'm guessing the dyn_clone dependency will still be necessary (as it keeps the trait safe).

[vi]

Is the code you are trying to build public, so that I can try to adapt it myself?

Do you use newly created type alias BoxedLanguage?

Do you have your own implementations of the Language trait (that are not included in the main timeago crate)?

[ghost]

Using BoxedLanguage works nice. Here's the crate that uses timeago: recoyx_localization.

[ghost]

Can you publish it again? Seems like it'll be backwards-compatible.

[vi]

as it keeps the trait safe

Was is a safe trait? I don't remember using any unsafe{} code in timeago.

[ghost]

I meant safe according to this Rust error.

[vi]

I meant safe according to this Rust error.

The correct term is "object safe". There is also unsafe trait ... {}, so just a "safe trait" could be confusing.

[vi]

Published v0.3.0

[ghost]

Thanks!