Added Swedish #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be OK if there be comma like in
|
vi
reviewed
Mar 26, 2018
| @@ -0,0 +1,40 @@ | |||
| use super::super::{Language, TimeUnit}; | |||
|
|
|||
| /// Default language for timeago | |||
There was a problem hiding this comment.
It's not a default language for timeago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title.
One small problem is that something like
5 minutes 3 seconds(in Swedish of course) sounds a bit weird to a natives speaker, it should have an “and” between the parts. I don’t want to mock around too much in the source, and the current way it is is fine.