fix(html-sanitize): replace html-sanitize with dom-purify because of bug #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package bug: apostrophecms/sanitize-html#547 postcss should not be used in a browser
ian-emsens-shd
approved these changes
Dec 13, 2022
| @@ -93,7 +94,6 @@ | |||
| "@types/react-router": "5.1.18", | |||
| "@types/react-router-dom": "5.3.3", | |||
| "@types/react-table": "7.7.10", | |||
| "@types/sanitize-html": "2.6.2", | |||
| "@typescript-eslint/eslint-plugin": "^5.41.0", | |||
| "@typescript-eslint/parser": "5.11.0", | |||
| "@viaa/avo2-components": "3.1.1", | |||
There was a problem hiding this comment.
Duplicate dependency?
There was a problem hiding this comment.
You added that.
One is a peer dependency, but you added it to dev dependencies as well to make sure it is always installed in the developer machine.
although i ran into the issue a few times where i update the peer dependency and nothing changes, because i also need to change it in the dev dependency section
Comment on lines
+11
to
+13
| import { compact, get } from 'lodash-es'; | ||
| import moment from 'moment'; | ||
| import React, { FunctionComponent } from 'react'; |
There was a problem hiding this comment.
Doesn't this throw linting warnings about import groups?
There was a problem hiding this comment.
no for me it doesn't
might have something to do with the monorepo and split version of the .eslint config file
I'll look at it some other time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package bug:
apostrophecms/sanitize-html#547
postcss should not be used in a browser