Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #213: update golang version to 1.21 #216

Merged
merged 1 commit into from Nov 10, 2023

Conversation

blinkeye
Copy link
Contributor

@blinkeye blinkeye commented Nov 6, 2023

fix #213.

@dosubot dosubot bot added the kind:enhancement New feature or request label Nov 6, 2023
@devstein devstein self-requested a review November 7, 2023 00:48
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a PR to upgrade @blinkeye!

Can you checkout the CI test failure and fix?

@blinkeye
Copy link
Contributor Author

blinkeye commented Nov 7, 2023

Hi @devstein, I made the necessary fix to the github workflow file, but I can't start the workflow myself to validate, you may re-run it if you so please.

@devstein devstein merged commit 042c062 into viaduct-ai:master Nov 10, 2023
3 checks passed
@devstein
Copy link
Collaborator

@blinkeye Thanks for contributing! I'll push a release this weekend

@blinkeye
Copy link
Contributor Author

Hi @devstein, can I kindly ask you to release a new version?

@devstein
Copy link
Collaborator

@blinkeye Thanks for the ping! Let me know if you run into issues in the new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update golang version from 1.19 to 1.21
2 participants