Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update Typheous due to grac dependency #10

Closed
gadimbaylisahil opened this issue Dec 13, 2021 · 4 comments
Closed

Unable to update Typheous due to grac dependency #10

gadimbaylisahil opened this issue Dec 13, 2021 · 4 comments

Comments

@gadimbaylisahil
Copy link

gadimbaylisahil commented Dec 13, 2021

Hi, Viafintech team!

Firstly, thanks for building this client which was useful for us over the years.

We have run into the issue where we can't use up to date version of Typheous, anything over 0.6.9 to be exact, as grac has a lock on it. With older versions of Typheous installation, we run into segmentation faults, which I am trying to debug. But considering it being 7 years old, maybe it's time for an update.

I would go ahead and create a PR, but considering the grac gem is also built by you, I am asking this to know how big of an interface change would it be.

Can we update grac to up to date version without much hassle? If so, will you accept the changes?

Thanks

@gadimbaylisahil
Copy link
Author

gadimbaylisahil commented Dec 13, 2021

I have updated it(~> 4) in a private repo for our own use and we did not have any regressions.

Specs also pass.

When reading the changelog of grac, I do not see any major changes except:

Grac now raises an exception on receiving only a partial response. This can happen when typhoeus times out while not having received the entire response. on 2.4.0.

@tobischo
Copy link
Member

Hi @gadimbaylisahil

The update should not cause any issues. The partial response handling would otherwise result in an invalid json error, so in that regard, only the exception that was raised is different, but not whether an exception is raised

martinseener added a commit that referenced this issue Dec 14, 2021
#10: Update gem dependencies and bump version
@tobischo
Copy link
Member

I published v2.2.0 with updated dependencies now

@gadimbaylisahil
Copy link
Author

@tobischo appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants