Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is package-lock.json ignored ? #23

Closed
cpoppema opened this issue Jul 5, 2017 · 0 comments
Closed

Why is package-lock.json ignored ? #23

cpoppema opened this issue Jul 5, 2017 · 0 comments

Comments

@cpoppema
Copy link

cpoppema commented Jul 5, 2017

Version

master

File / Feature

.gitignore

Expected behaviour

Track the file package-lock.json

Actual behaviour

package-lock.json is ignored.

Stacktrace / Error message

-

Other info

package-lock.json has a very specific purpose. This is useful so new builds use the exact same versions this repository guaranteed to be working. This is also required to have a successful review process for Firefox builds: if versions have been bumped after building the xpi/before a reviewer starts building from provided source files and the output is different you have a rejected build and can start over.

TomOffringa pushed a commit that referenced this issue Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant