RSDK-6058 Deprecate sensors service api

[randhid]

This pull request marks the sensors service API as deprecated. This will be removed once the RC card for sensors no longer has a dependency on the GetAllReadings Function.

[penguinland]

LGTM. It's exciting to get rid of this!

[penguinland]

I think that in addition to giving RPCs the deprecated option, you can do that to entire messages, too. Worth doing here? I dunno; what you've got is already pretty thorough.

[randhid]

nice! I am not a proto expert, had to google what to actually do here. I don't see the harm in just adding deprecated signifiers everywhere we can.

[penguinland]

I think it's:

message GetSensorsResponse {
    option deprecated = true;
    repeated common.v1.ResourceName sensor_names = 1 [deprecated = true]; 
    ...
}

but I've never done this myself and could be wrong.

[randhid]

Okay I'm satisfied. I will check with a local version of this API with rdk tomorrow to make sure things work as expected and won't break anything juts by adding a deprecated signifier to proto.

[randhid]

This pull request marks the sensors service API as deprecated. This will be removed once the RC card for sensors no longer has a dependency on the GetAllReadings Function.

Finally taste with a local build of the API following instructions here, in case anyone was wondering about the method I used to test.

Tested with the python SDK using the following code:

    service = SensorsClient.from_robot(robot, "builtin")
    sensors = await service.get_sensors()
    print(f"b get_readings return value: {sensors}")

    vals = await service.get_readings(sensors)
    print(f"b get_readings return value: {vals}")

Got back:

get_sensors return value: [<viam.proto.common.ResourceName rdk:component:sensor/b at 0x103ee7b30>, <viam.proto.common.ResourceName rdk:component:sensor/c at 0x103ee76d0>, <viam.proto.common.ResourceName rdk:component:sensor/a at 0x103ee7680>]
get_readings return value: {<viam.proto.common.ResourceName rdk:component:sensor/b at 0x103ee7a40>: {'a': 1.0, 'b': 2.0, 'c': 3.0}, <viam.proto.common.ResourceName rdk:component:sensor/c at 0x103ee7c20>: {'a': 1.0, 'b': 2.0, 'c': 3.0}, <viam.proto.common.ResourceName rdk:component:sensor/a at 0x103ee71d0>: {'a': 1.0, 'b': 2.0, 'c': 3.0}}

RC Card is still functional (three fake sensors configured):

I'm happy, will merge in.

[penguinland]

Rand thinks the PR is stuck in some weird CI edge case, and needs another LGTM to get unstuck...